src: add perfetto trace agent

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64565
Refs: nodejs/diagnostics#654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>

Author: legendecas

node.gyp

@@ -455,6 +455,10 @@
       'src/node_crypto.h',
     ],
     'node_tracing_perfetto_sources': [
+      'src/tracing/agent_perfetto.cc',
+      'src/tracing/agent_perfetto.h',
+      'src/tracing/trace_event_perfetto.cc',
+      'src/tracing/trace_event_perfetto.h',
     ],
     'node_tracing_legacy_sources': [
       'src/tracing/agent_legacy.cc',

src/inspector/node_inspector.gypi

@@ -24,8 +24,6 @@
       'src/inspector/protocol_helper.h',
       'src/inspector/runtime_agent.cc',
       'src/inspector/runtime_agent.h',
-      'src/inspector/tracing_agent.cc',
-      'src/inspector/tracing_agent.h',
       'src/inspector/worker_agent.cc',
       'src/inspector/worker_agent.h',
       'src/inspector/network_inspector.cc',
@@ -51,6 +49,10 @@
       'src/inspector/notification_emitter.h',
       'src/inspector/notification_emitter.cc',
     ],
+    'node_inspector_without_perfetto_sources': [
+      'src/inspector/tracing_agent.cc',
+      'src/inspector/tracing_agent.h',
+    ],
     'node_inspector_generated_sources': [
       '<(SHARED_INTERMEDIATE_DIR)/src/node/inspector/protocol/Forward.h',
       '<(SHARED_INTERMEDIATE_DIR)/src/node/inspector/protocol/Protocol.cpp',
@@ -185,4 +187,11 @@
       ],
     },
   ],
+  'conditions': [
+    ['v8_use_perfetto!=1', {
+      'sources': [
+        '<@(node_inspector_without_perfetto_sources)',
+      ],
+    }],
+  ],
 }

src/node_options.h

@@ -333,7 +333,11 @@ class PerProcessOptions : public Options {
 
   std::string title;
   std::string trace_event_categories;
+#if defined(V8_USE_PERFETTO)
+  std::string trace_event_file_pattern = "node_trace.${rotation}.pftrace";
+#else
   std::string trace_event_file_pattern = "node_trace.${rotation}.log";
+#endif
   int64_t v8_thread_pool_size = 4;
   bool zero_fill_all_buffers = false;
   bool debug_arraybuffer_allocations = false;

src/tracing/agent.cc

@@ -1,6 +1,12 @@
 #include "tracing/agent.h"
+
+#ifdef V8_USE_PERFETTO
+#include "tracing/agent_perfetto.h"
+#else
 #include "tracing/agent_legacy.h"
-#include "tracing/trace_event.h"
+#endif
+
+#include "tracing/trace_event_helper.h"
 
 namespace node {
 namespace tracing {
@@ -23,7 +29,11 @@ void Agent::Deleter::operator()(Agent* agent) {
 std::unique_ptr<Agent, Agent::Deleter> Agent::CreateDefault() {
   CHECK_NULL(g_agent);
 
+#ifdef V8_USE_PERFETTO
+  auto agent = new PerfettoTracingAgent();
+#else
   auto agent = new LegacyTracingAgent();
+#endif
 
   g_agent = agent;
   TraceEventHelper::SetTracingController(agent->GetTracingController());

src/tracing/agent.h

@@ -43,9 +43,9 @@ class Agent {
   virtual AgentWriterHandle* GetDefaultWriterHandle() = 0;
 
   virtual void AddTraceStateObserver(
-      v8::TracingController::TraceStateObserver* observer) = 0;
+      v8::TracingController::TraceStateObserver* observer) {}
   virtual void RemoveTraceStateObserver(
-      v8::TracingController::TraceStateObserver* observer) = 0;
+      v8::TracingController::TraceStateObserver* observer) {}
 
   struct Deleter {
     void operator()(Agent* agent);
@@ -88,6 +88,7 @@ class AgentWriterHandle {
 
   friend class Agent;
   friend class LegacyTracingAgent;
+  friend class PerfettoTracingAgent;
 };
 
 void AgentWriterHandle::reset() {