Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 62dd1d7bd48d03324c58a0c8fda3e6a507a95bb0
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0157e3ebca5692620090b2c1f1abede81512bc87
Choose a head ref
  • 2 commits
  • 11 files changed
  • 1 contributor

Commits on Nov 20, 2018

  1. deps: V8: partially revert d868eb7 

    d868eb7 ended up being an inadvertant ABI change. Remove the call to
CheckMemoryPressure from the header itself.

PR-URL: #24499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @ofrobots @MylesBorins
    ofrobots authored and MylesBorins committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    5245d6a View commit details
    Browse the repository at this point in the history

  2. src,deps: add ABI safe use of CheckMemoryPressure 

    CheckMemoryPressure cannot be used ABI-safely from v8.h. Add a alternate
implementation of AdjustAmountOfExternalAllocatedMemory and then use
that from Node.

PR-URL: #24499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @ofrobots @MylesBorins
    ofrobots authored and MylesBorins committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    0157e3e View commit details
    Browse the repository at this point in the history
Loading