Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 85852a3221b17f4d10d35e9abf94d676a81c3120
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8cfcf52db832bf7c8200470cc87a1159816a52e4
Choose a head ref
  • 4 commits
  • 8 files changed
  • 1 contributor

Commits on Dec 2, 2025

  1. deps,src: prepare for cpplint update 

    Disable linting where there are false positives or clashes whith the C++
formatter.

PR-URL: #60901
Fixes: #60771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
    @targos @nodejs-github-bot
    targos authored and nodejs-github-bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    09c4f6f View commit details
    Browse the repository at this point in the history

  2. tools: disable some new cpplint rules before update 

    PR-URL: #60901
Fixes: #60771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
    @targos @nodejs-github-bot
    targos authored and nodejs-github-bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    fc85c7a View commit details
    Browse the repository at this point in the history

  3. tools: update cpplint to 2.0.2 

    PR-URL: #60901
Fixes: #60771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
    @targos @nodejs-github-bot
    targos authored and nodejs-github-bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    11813f9 View commit details
    Browse the repository at this point in the history

  4. tools: refloat 10 Node.js patches to cpplint.py 

    Cherry-pick 12c8b4d
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: #17373
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: 12c8b4d

Cherry-pick fc81e80
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: #21521
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: fc81e80

Cherry-pick cbc3dd9
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: #21010
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: cbc3dd9

Cherry-pick 9029981
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: #26306
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: 9029981

Cherry-pick 0a25ace
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: #27098
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: 0a25ace

Cherry-pick afa9a72
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: #30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: afa9a72

Cherry-pick e23bf8f
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: #31018
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Backport 3d954dc
Original commit message:

    tools: remove readability/fn_size rule

    PR-URL: #54663
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: 3d954dc

Cherry-pick c7d7ec7
Original commit message:

    tools: check for std::vector<v8::Local> in lint

    PR-URL: #58497
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs: c7d7ec7

Cherry-pick e6d94ef
Original commit message:

    tools: add C++ lint rule to avoid using `String::Utf8Value`

    We should be using our own helpers for this instead.

    PR-URL: #60244
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>

Refs: e6d94ef
PR-URL: #60901
Fixes: #60771
    @targos @nodejs-github-bot
    targos authored and nodejs-github-bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    8cfcf52 View commit details
    Browse the repository at this point in the history
Loading