Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e984917aaf161d810ff1acaf2f4b5e4e0b345315
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c3caf21bd35359fe8b0470a65775ade5979890f7
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 15, 2019

  1. deps: cherry-pick 721dc7d from node-gyp upstream 

    This change cherry-picks a small set of node-gyp v5.0.0 changes needed
to enable Node.js ARM64 Windows builds.

Original commit message:
  Add ARM64 to MSBuild /Platform logic

  PR-URL: nodejs/node-gyp#1655
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: João Reis <reis@janeasystems.com>

Refs: nodejs/node-gyp@721dc7d
PR-URL: #28604
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: João Reis <reis@janeasystems.com>
    @jkunkee @joaocgreis
    jkunkee authored and joaocgreis committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    d53144e View commit details
    Browse the repository at this point in the history

  2. deps: cherry-pick 91744bf from node-gyp upstream 

    This change cherry-picks a small set of node-gyp v5.0.0 changes needed
to enable Node.js ARM64 Windows builds.

Original commit message:
  gyp: add support for Windows on Arm

  Cherry-pick of refack/GYP3#33, supersedes
  nodejs/node-gyp#1678 until GYP3 is merged.

  `npm test` passes

  Change-Id: I2b1e1e03e378b4812d34afa527087793864d1576

  PR-URL: nodejs/node-gyp#1739
  Reviewed-By: Refael Ackermann <refack@gmail.com>
  Reviewed-By: João Reis <reis@janeasystems.com>

Refs: nodejs/node-gyp@91744bf
PR-URL: #28604
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: João Reis <reis@janeasystems.com>
    @jkunkee @joaocgreis
    jkunkee authored and joaocgreis committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    c3caf21 View commit details
    Browse the repository at this point in the history
Loading