Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fcb27fa7a18b00532cf22de85a44c76d5b16e6de
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4ffe804c81030eb8003a439e82b313159196caef
Choose a head ref
  • 2 commits
  • 1,033 files changed
  • 1 contributor

Commits on Jul 18, 2017

  1. build: check for linter in bin rather than lib 

    Make the "can we lint?" check in Makefile and vcbuild.bat depend on
bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js
is not present. The lint rules call bin/eslint.js so check for that
instead.

Backport-PR-URL: #14340
PR-URL: #13645
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    bb1b06a View commit details
    Browse the repository at this point in the history

  2. tools: update ESLint to v4.0.0 

    Update ESLint and configuration to version 4.0.0.

Backport-PR-URL: #14340
PR-URL: #13645
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    4ffe804 View commit details
    Browse the repository at this point in the history
Loading