test: add fs-assert-encoding's test#10913
Closed
hiroppy wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
test
cjihrig
requested changes
Jan 20, 2017
Contributor
There was a problem hiding this comment.
Can you create a noop variable, give it the value of () => {}, then just reuse that.
hiroppy
force-pushed
the
feature/add-test-fs-assert-encoding-error
branch
from
a652769 to
96b89c1
Compare
cjihrig
approved these changes
Jan 20, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
One more small nit, but LGTM
Contributor
There was a problem hiding this comment.
Since options never changes, you can just use test in the regex, and use a literal instead of the RegExp() constructor.
Check the error of `assertEncoding`. Confirmed in every place being used.(a place where `getoptions` is used) assetEncoding: https://github.com/nodejs/node/blob/521767c88605cb6481ea98f396924e55f9dd22f4/lib/internal/fs.js#L18
hiroppy
force-pushed
the
feature/add-test-fs-assert-encoding-error
branch
from
96b89c1 to
1f6fd2f
Compare
Contributor
jasnell
approved these changes
Jan 23, 2017
lpinca
approved these changes
Jan 25, 2017
Member
|
|
Member
|
Ops I messed up. |
Member
|
@lpinca you can still |
Member
|
@gibfahn yes thanks, but I only closed the wrong PR by mistake :) |
Member
Author
|
@lpinca Can I merge to master? |
Member
|
@abouthiroppy sure. |
Member
Author
Member
Author
|
|
Member
|
Yes, there are some failures on |
hiroppy
added a commit
that referenced
this pull request
Feb 1, 2017
Check the error of `assertEncoding`. Confirmed in every place being used.(a place where `getoptions` is used) assetEncoding: https://github.com/nodejs/node/blob/521767c88605cb6481ea98f396924e55f9dd22f4/lib/internal/fs.js#L18 PR-URL: #10913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in 9db8973. |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 2, 2017
Check the error of `assertEncoding`. Confirmed in every place being used.(a place where `getoptions` is used) assetEncoding: https://github.com/nodejs/node/blob/521767c88605cb6481ea98f396924e55f9dd22f4/lib/internal/fs.js#L18 PR-URL: nodejs#10913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Check the error of `assertEncoding`. Confirmed in every place being used.(a place where `getoptions` is used) assetEncoding: https://github.com/nodejs/node/blob/521767c88605cb6481ea98f396924e55f9dd22f4/lib/internal/fs.js#L18 PR-URL: nodejs#10913 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
This is not landing cleanly on v6 or v4. Backport? |
Member
|
Test fails on both v4 and v6 btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the error of
assertEncoding.Confirmed in every place being used.(a place where getOptions is used)
assetEncoding:
node/lib/internal/fs.js
Line 18 in 521767c
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test