test: use repeat() instead of new Array().join()#11071
Closed
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Closed
test: use repeat() instead of new Array().join()#11071JacksonTian wants to merge 1 commit intonodejs:masterfrom
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Conversation
lpinca
approved these changes
Jan 30, 2017
Contributor
|
First line of the commit message is a tad too long. Perhaps use: 'test: use repeat() instead of new Array().join()' ? |
evanlucas
approved these changes
Jan 30, 2017
Contributor
evanlucas
left a comment
evanlucas
left a comment
There was a problem hiding this comment.
LGTM with Brian's nit fixed
cjihrig
approved these changes
Jan 30, 2017
The usage of `new Array(length + 1).join(str)` is strange. Change to `str.repeat(length)` is more clearly.
Contributor
Author
|
Used the shorter commit message. Thanks all. |
JacksonTian
changed the title
jasnell
approved these changes
Jan 30, 2017
Contributor
targos
approved these changes
Jan 31, 2017
hiroppy
approved these changes
Feb 2, 2017
italoacasas
approved these changes
Feb 2, 2017
|
Landed 58dc229 |
italoacasas
pushed a commit
that referenced
this pull request
Feb 2, 2017
The usage of `new Array(length + 1).join(str)` is strange. Change to `str.repeat(length)` is more clearly. PR-URL: #11071 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 3, 2017
The usage of `new Array(length + 1).join(str)` is strange. Change to `str.repeat(length)` is more clearly. PR-URL: #11071 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
The usage of `new Array(length + 1).join(str)` is strange. Change to `str.repeat(length)` is more clearly. PR-URL: nodejs#11071 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Member
|
will require a backport PR to land on v6 or v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of
new Array(length + 1).join(str)is strange.Change to
str.repeat(length)is more clearly.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test