Closed
Conversation
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures
Trott
added
repl
addaleax
approved these changes
Feb 11, 2017
cjihrig
approved these changes
Feb 11, 2017
jasnell
approved these changes
Feb 11, 2017
lpinca
approved these changes
Feb 12, 2017
thefourtheye
approved these changes
Feb 12, 2017
Contributor
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
LGTM if CI is happy.
| assert.notStrictEqual(stdout.indexOf('42042\n'), -1); | ||
| assert.ok( | ||
| stdout.includes('Script execution interrupted.\n'), | ||
| `Expected stdout to contain "Script execution interrupted.", got ${stdout}` |
Contributor
There was a problem hiding this comment.
Nit: \n is missing in the expected string.
Member
Author
There was a problem hiding this comment.
I left it out because a literal \n in the message output would probably be unhelpful and an escaped \n might be taken to mean that an escaped \n is what is expected.
I'm OK with any of the three possibilities (leave it out, put it in literally, put it in escaped). I chose this one (leave it out) for simplicity. If you feel that it should be there, let me know if you want it escaped or not. And if, like me, you don't feel particularly strongly, then I'll probably just leave it as it is. ¯\(ツ)/¯
Member
Author
jasnell
pushed a commit
that referenced
this pull request
Feb 13, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: #11309 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Landed in f2023d7 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: nodejs#11309 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: #11309 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Needs a backport PR to land on v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: #11309 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test repl