doc: adding deprecations.md#11621
Closed
italoacasas wants to merge 1 commit intonodejs:v7.x-stagingfrom
Closed
Conversation
Merged
sam-github
approved these changes
Feb 28, 2017
jasnell
approved these changes
Feb 28, 2017
Contributor
|
@italoacasas since this is a backport, you don't have to wait to merge into the v7.x-staging/proposal branches. |
Member
|
Aside: I'm wondering if the intent above was to @-mention nodejs/collaborators rather than nodejs/collaboration. Is nodejs/collaboration active anymore? Might be good to remove (or else rename) to avoid this kind of confusion. I've certainly auto-completed to |
Author
|
Yes, that was the intent, second time this happens to me xD... Landing this in 10m... |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 28, 2017
PR-URL: nodejs#11621 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Author
|
Landed |
Member
|
Marking as don't land on 4 and 6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
This file doesn't exist in v7.x because every commit was a
semver-major. Now we have an exception because the backport for thenode --debugdeprecation.The release for 7.7.0 is going to be delayed if we don't fast track this backport, since the build is failing because this other commit was included in staging already.
This backport is, in my opinion, the correct fix.
cc: @nodejs/collaboration