doc: reduce font size on smaller screens#11695
Closed
gibfahn wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919
watilde
approved these changes
Mar 5, 2017
Contributor
|
cc @Fishrock123. |
Contributor
|
@gibfahn can you show some comparision screenshots? |
Contributor
|
I'm not exactly up-to-date on media queries, aren't some cellphones in this range? I'm not sure if there is other fancy new detection we can do? |
Contributor
|
According to http://mydevice.io/devices/, the highest phone CSS width is 504px in portrait and 768px in landscape mode, so I'd say it's pretty good as-is. |
fhinkel
approved these changes
Mar 9, 2017
Member
|
Thanks. Landed in 7c8bbe3. |
fhinkel
pushed a commit
that referenced
this pull request
Mar 9, 2017
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919 PR-URL: #11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 13, 2017
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919 PR-URL: nodejs#11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919 PR-URL: nodejs#11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919 PR-URL: #11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919 PR-URL: #11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: nodejs/nodejs.org#919 PR-URL: nodejs/node#11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
How it looks like today:
Apparently the issue hasn't been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The font size for tablet sized screens (or half a laptop screen) is overly
large, reduce it to a more readable size.
Fixes: nodejs/nodejs.org#919
Checklist
Affected core subsystem(s)
doc