benchmark: reduce string concatenations by vsemozhetbyt · Pull Request #12455 · nodejs/node

vsemozhetbyt · 2017-04-17T02:12:55Z

Checklist

tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

benchmark

I. Presupposition

String concatenations usually increase syntax noise and add confusion (a reader often has to check if string concatenation or number addition is intended). Moreover, it seems this method is not optimal performance-wise.

II. Cases

This PR aims two cases of string concatenation:

multipart concatenations with variable interpolation ('a' + b + 'c');
type coercion to String ('' + notString). This approach, while idiomatic, is not most declarative.

III. Performance

The added benchmark compares these variants:

'a' + b + 'c' vs ['a', b, 'c'].join('') vs `a${b}c`
String(notString) vs '' + notString vs `${notString}`

Results with Node.js 8.0.0 rc:

es\string-concatenations.js mode="multi-concat"       n=1000:   909,455.5180758832
es\string-concatenations.js mode="multi-join"         n=1000:   290,896.9895943238
es\string-concatenations.js mode="multi-template"     n=1000: 2,620,236.0832711025

es\string-concatenations.js mode="to-string-string"   n=1000: 6,020,179.642160523
es\string-concatenations.js mode="to-string-concat"   n=1000: 1,141,656.7723079734
es\string-concatenations.js mode="to-string-template" n=1000: 5,700,376.794906143

IV. Commits

Reduce string concatenations: replace concatenations with template literals, rewrap,
String.prototype.repeat(), String(). Some replacements do not add indisputable readability gain, but I tried to be consistent.
Add a benchmark for string concatenations vs counterparts.
This commit is added here to avoid PR race condition and merge conflicts. It fixes an URL in _http-benchmarkers.js (removes duplicate hash symbol).
This commit is added here to avoid PR race condition and merge conflicts. It fixes an evident typo in _http-benchmarkers.js: Error() constructor has only one parameter, while callback() has 5 (compare a previous call and callback() signature).

All changed files were minimally tested. CI for linting and new tests concerning benchmarks will be launched.

vsemozhetbyt · 2017-04-17T02:33:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7434/

mscdex · 2017-04-17T02:50:10Z

benchmark/assert/deepequal-typedarrays.js

Indented too far.

mscdex · 2017-04-17T02:50:47Z

benchmark/_http-benchmarkers.js

Why the odd indentation here and elsewhere? Shouldn't they line up with the beginning of the string?

I've tried to stress the subordinate state of the next part. I'll try to decrease indentation.

mscdex · 2017-04-17T02:52:51Z

benchmark/_benchmark_progress.js

FWIW I'm not particularly a fan of this style to avoid the extra spacing.

Can you elaborate?

Using ${ followed by a newline to avoid including spaces due to indentation.

vsemozhetbyt · 2017-04-17T03:17:23Z

Some indentation was reduced. New CI: https://ci.nodejs.org/job/node-test-pull-request/7435/

benjamingr · 2017-04-17T08:53:01Z

benchmark/buffers/buffer-bytelength.js

It's funny we even had a recursive implementation :D

Yeah, I am even sorry to retire it)

benjamingr · 2017-04-17T08:54:13Z

benchmark/buffers/buffer-write.js

benjamingr · 2017-04-17T08:54:49Z

benchmark/common.js

console.error('bad argument:', arg) ?

I think this would imply we need inspect() for arg (as we do for Error objects), while arg is a simple string.

jasnell · 2017-04-17T18:13:49Z

benchmark/buffers/buffer-read.js

just a reminder that this will make it impossible to run these benchmarks to compare against anything older than 4.0.0. That's not an objection, by any means.

Yes, but there were many other template literals in benchmarks before this edition, including common.js.

At this point I don't think it really matters. I can't see anyone wanting to run the benchmarks for v0.10 or v0.12 anymore, especially since it wouldn't really do any good (it's not as if the V8 team can/will revert to v0.10/v0.12-era V8 code if there is a performance issue in node v4.x+).

Yep, as I said, it's not an objection. Just noting the change. We may want to let folks know just so that they're aware.

I think a lot of benchmarks don't run on v4.x or older anyways...I've seen people on IRC
asking why some benchmark doesn't run and turns out they are using v4.x to run it

jasnell

LGTM

jasnell · 2017-04-17T18:15:47Z

benchmark/buffers/buffer-swap.js

Definitely not a fan of multiline literals.

vsemozhetbyt · 2017-04-19T15:35:03Z

New CI to be sure: https://ci.nodejs.org/job/node-test-pull-request/7520/

vsemozhetbyt · 2017-04-19T16:49:28Z

1 Linux fail seems unrelated. Timeout in sequential/test-benchmark-child-process on Windows. Trying again: https://ci.nodejs.org/job/node-test-pull-request/7522/

UPD. Waiting for #12518

vsemozhetbyt · 2017-04-19T23:03:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7538/

Sigh... Aborted. New CI: https://ci.nodejs.org/job/node-test-pull-request/7539/
Conflict resolved. New CI: https://ci.nodejs.org/job/node-test-pull-request/7540/

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt · 2017-04-20T01:51:28Z

Landed in bbbb1f6...d8965d5

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: nodejs#12735 Refs: nodejs#12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Backport-PR-URL: #13835 PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

vsemozhetbyt added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 17, 2017

mscdex reviewed Apr 17, 2017

View reviewed changes

benchmark/assert/deepequal-typedarrays.js Outdated

Copy link

Contributor

mscdex Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indented too far.

vsemozhetbyt reacted with thumbs up emoji

mscdex reviewed Apr 17, 2017

View reviewed changes

benjamingr reviewed Apr 17, 2017

View reviewed changes

benchmark/buffers/buffer-write.js Outdated

Copy link

Member

benjamingr Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer

vsemozhetbyt reacted with thumbs up emoji

benjamingr reviewed Apr 17, 2017

View reviewed changes

benjamingr approved these changes Apr 17, 2017

View reviewed changes

jasnell reviewed Apr 17, 2017

View reviewed changes

jasnell approved these changes Apr 17, 2017

View reviewed changes

benchmark/buffers/buffer-swap.js Outdated

Copy link

Member

jasnell Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a fan of multiline literals.

vsemozhetbyt added 4 commits April 20, 2017 03:51

benchmark: reduce string concatenations

cbfa141

benchmark: add benchmark for string concatenations

3c800ef

benchmark: fix URL in _http-benchmarkers.js

c61bdd7

benchmark: fix typo in _http-benchmarkers.js

620a87c

vsemozhetbyt added a commit that referenced this pull request Apr 20, 2017

benchmark: reduce string concatenations

22aa3d4

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt added a commit that referenced this pull request Apr 20, 2017

benchmark: add benchmark for string concatenations

3b1e837

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt added a commit that referenced this pull request Apr 20, 2017

benchmark: fix URL in _http-benchmarkers.js

a3778cb

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt added a commit that referenced this pull request Apr 20, 2017

benchmark: fix typo in _http-benchmarkers.js

d8965d5

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt closed this Apr 20, 2017

vsemozhetbyt deleted the bench-templates branch April 20, 2017 01:51

evanlucas pushed a commit that referenced this pull request Apr 25, 2017

benchmark: add benchmark for string concatenations

ebc9593

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt mentioned this pull request Apr 28, 2017

test: reduce string concatenations #12735

Closed

24 tasks

evanlucas mentioned this pull request May 1, 2017

v7.10.0 proposal #12775

Merged

evanlucas pushed a commit that referenced this pull request May 1, 2017

benchmark: add benchmark for string concatenations

ec32e01

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas pushed a commit that referenced this pull request May 2, 2017

benchmark: add benchmark for string concatenations

7d87edc

PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt added a commit that referenced this pull request May 5, 2017

test: reduce string concatenations

8b76c3e

PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017

test: reduce string concatenations

50d2298

PR-URL: nodejs#12735 Refs: nodejs#12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

gibfahn added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels May 16, 2017

jasnell mentioned this pull request May 11, 2017

8.0.0 Release Proposal #12220

Closed

MylesBorins pushed a commit that referenced this pull request Jul 10, 2017

test: reduce string concatenations

0dfb19d

PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jul 10, 2017

test: reduce string concatenations

35b55bf

Backport-PR-URL: #13835 PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins pushed a commit that referenced this pull request Jul 11, 2017

test: reduce string concatenations

5b74e63

Backport-PR-URL: #13835 PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018

Uh oh!

Conversation

vsemozhetbyt commented Apr 17, 2017

Checklist

Affected core subsystem(s)

I. Presupposition

II. Cases

III. Performance

IV. Commits

Uh oh!

vsemozhetbyt commented Apr 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mscdex Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt commented Apr 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mscdex Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt commented Apr 19, 2017

Uh oh!

vsemozhetbyt commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vsemozhetbyt commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vsemozhetbyt commented Apr 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mscdex Apr 17, 2017 •

edited

Loading

vsemozhetbyt Apr 17, 2017 •

edited

Loading

mscdex Apr 17, 2017 •

edited

Loading

vsemozhetbyt commented Apr 19, 2017 •

edited

Loading

vsemozhetbyt commented Apr 19, 2017 •

edited

Loading