test: use assert regexp in tls no cert test#12891
Closed
arturgvieira-zz wants to merge 1 commit intonodejs:masterfrom
arturgvieira-zz:feature-branch
Closed
test: use assert regexp in tls no cert test#12891arturgvieira-zz wants to merge 1 commit intonodejs:masterfrom arturgvieira-zz:feature-branch
arturgvieira-zz wants to merge 1 commit intonodejs:masterfrom
arturgvieira-zz:feature-branch
Conversation
refack
approved these changes
May 8, 2017
Contributor
|
@arturgvieira thank you very much for the contribution 🥇 |
Trott
approved these changes
May 8, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green.
Might be nice to put the regexp on its own line to keep everything to 80 chars or less. Not required, though. (When it eventually gets replaced with common.expectsError(), it will get wrapped at that time, so I'm not going to sweat it.)
Author
cjihrig
approved these changes
May 8, 2017
Contributor
There was a problem hiding this comment.
Can you indent this please.
Author
|
@cjihrig Just fixed it. |
DavidCai1111
approved these changes
May 8, 2017
Member
lpinca
approved these changes
May 8, 2017
Member
|
@arturgvieira can you please run |
Author
|
@lpinca Fixed the lint error, trailing spaces. |
Member
thefourtheye
approved these changes
May 8, 2017
Contributor
|
Rerun macOS CI:https://ci.nodejs.org/job/node-test-commit-osx/9635/ |
jasnell
approved these changes
May 9, 2017
Replace the assert throws second argument from a contructor to a regexp matching the entire error message.
arturgvieira-zz
changed the title
refack
pushed a commit
to refack/node
that referenced
this pull request
May 10, 2017
Replace the `assert.throws` second argument from a Type to a `RegExp` matching the entire error message. Error message changes are `semver-major`, so we assert their content. PR-URL: nodejs#12891 Refs: nodejs#12603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in cfe7b34 |
Contributor
|
Post land CI:https://ci.nodejs.org/job/node-test-commit/9785/ |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
Replace the `assert.throws` second argument from a Type to a `RegExp` matching the entire error message. Error message changes are `semver-major`, so we assert their content. PR-URL: nodejs#12891 Refs: nodejs#12603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
Replace the `assert.throws` second argument from a Type to a `RegExp` matching the entire error message. Error message changes are `semver-major`, so we assert their content. PR-URL: #12891 Refs: #12603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
Replace the `assert.throws` second argument from a Type to a `RegExp` matching the entire error message. Error message changes are `semver-major`, so we assert their content. PR-URL: #12891 Refs: #12603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the assert throws second argument from a contructor to a regexp
matching the entire error message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test tls