src: correct endif comment SRC_NODE_API_H__#13190
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
src: correct endif comment SRC_NODE_API_H__#13190danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten.
nodejs-github-bot
added
c++
addaleax
approved these changes
May 24, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I’d dare say this doesn’t need 48 hours to land ;)
cjihrig
approved these changes
May 24, 2017
jasnell
approved these changes
May 24, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM. This shouldn't need to wait the 48 hours to land
danbev
added a commit
to danbev/node
that referenced
this pull request
May 24, 2017
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten. PR-URL: nodejs#13190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Landed in 260cd41 |
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten. PR-URL: #13190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten. PR-URL: #13190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten. PR-URL: nodejs#13190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Really minor but I could not find an open PR for anything n-api where this could be changed, so creating this so that it is not forgotten. Backport-PR-URL: #19447 PR-URL: #13190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really minor but I could not find an open PR for anything n-api where
this could be changed, so creating this so that it is not forgotten.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src