stream: remove dup property#13216
Merged
calvinmetcalf merged 1 commit intonodejs:masterfrom May 25, 2017
Merged
Conversation
nodejs-github-bot
added
the
stream
lpinca
approved these changes
May 25, 2017
cjihrig
approved these changes
May 25, 2017
Contributor
Author
|
considering how trivial this is I'll plan on landing this in the next hour or 2 unless anyone objects |
addaleax
approved these changes
May 25, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Agreed, I’m good with landing this now
Contributor
Author
|
@addaleax whats your email so I can include you in the reviewed lines ? |
Member
|
@calvinmetcalf anna@addaleax.net … if you’re unsure about those, you can always just copy the lines from our README :) |
Member
|
@calvinmetcalf I usually copy/paste the latest available in |
PR-URL: nodejs#13216 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
calvinmetcalf
force-pushed
the
stream-final-dup-prop
branch
from
fed32a6 to
155687c
Compare
Contributor
Author
|
@lpinca I had been doing that but couldn't find it in any recent ones and totally forgot about her email in the readme |
Contributor
Author
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
PR-URL: #13216 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13216 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like #12828 accidentally got a double property definition, as mentioned here, this removes that