doc: add ref to option to enable n-api#13406
Closed
mhdawson wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Since its guarded in by a command line option say that in the docs and provide the option that needs to be used to enable it.
nodejs-github-bot
added
doc
cjihrig
approved these changes
Jun 2, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM.
It might be better to add this a little further down, where #include <node_api.h> is first introduced. Feel free to ignore if you want though.
tniessen
approved these changes
Jun 2, 2017
jasongin
reviewed
Jun 2, 2017
doc/api/n-api.md
Outdated
| recompilation. | ||
|
|
||
| As the feature is currently experimental it must be enabled with the | ||
| following command line option: |
Member
There was a problem hiding this comment.
Should this link to https://nodejs.org/dist/latest-v8.x/docs/api/cli.html#cli_napi_modules
Member
Author
|
Pushed commit to address comments. |
jasongin
approved these changes
Jun 5, 2017
gibfahn
approved these changes
Jun 5, 2017
Member
Author
Member
Author
|
GI good, landed as 7d9dfda. |
mhdawson
added a commit
that referenced
this pull request
Jun 5, 2017
Since its guarded in by a command line option say that in the docs and provide the option that needs to be used to enable it. PR-URL: #13406 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießn <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Contributor
|
Ohh cool, I'm an options now 😆 |
jasnell
pushed a commit
that referenced
this pull request
Jun 7, 2017
Since its guarded in by a command line option say that in the docs and provide the option that needs to be used to enable it. PR-URL: #13406 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießn <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Since its guarded in by a command line option say that in the docs and provide the option that needs to be used to enable it. PR-URL: nodejs#13406 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießn <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Since its guarded in by a command line option say that in the docs and provide the option that needs to be used to enable it. Backport-PR-URL: #19447 PR-URL: #13406 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießn <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since its guarded in by a command line option say
that in the docs and provide the option that needs
to be used to enable it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, n-api