url: remove unused setURLConstructor function#46485
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 5, 2023
Merged
url: remove unused setURLConstructor function#46485nodejs-github-bot merged 1 commit intonodejs:mainfrom
setURLConstructor function#46485nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
anonrig
added
url
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
lpinca
approved these changes
Feb 3, 2023
anonrig
added
the
author ready
himself65
approved these changes
Feb 3, 2023
anonrig
added
the
commit-queue
ronag
approved these changes
Feb 4, 2023
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Feb 4, 2023
22 tasks
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f013950 |
19 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46485 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46485 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing it before #46410 lands.