buffer: graduate File from experimental and expose as global #47153

KhafraDev · 2023-03-18T21:34:05Z

Undici has been using the native File class by default for over 3 months now, and we haven't had a single issue reported about it or using it with fetch/FormData. It's a very small wrapper around Blob too, I don't personally see much reason in keeping a class with 2 additional properties experimental.

I based this commit heavily on jasnell's which made Blob global, lmk if I'm missing something

nodejs-github-bot · 2023-03-18T21:34:09Z

Review requested:

@nodejs/startup

doc/api/globals.md

anonrig · 2023-03-20T20:40:07Z

@nodejs/tsc @nodejs/buffer Can you review please?

doc/api/buffer.md

doc/api/globals.md

nodejs-github-bot · 2023-03-20T21:26:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50500/

mcollina

lgtm

nodejs-github-bot · 2023-03-21T03:43:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50507/

GeoffreyBooth

Does its API match the browser counterpart? Assuming it does, this seems fine to me.

nodejs-github-bot · 2023-03-21T12:31:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50514/

KhafraDev · 2023-03-21T13:31:41Z

Does its API match the browser counterpart? Assuming it does, this seems fine to me.

yes it's a 1:1 match

nodejs-github-bot · 2023-03-21T18:50:18Z

Commit Queue failed

- Loading data for nodejs/node/pull/47153
✔  Done loading data for nodejs/node/pull/47153
----------------------------------- PR info ------------------------------------
Title      buffer: graduate File from experimental and expose as global (#47153)
Author     Khafra  (@KhafraDev)
Branch     KhafraDev:make-file-global -> nodejs:main
Labels     semver-major, author ready, needs-ci, commit-queue-squash
Commits    2
 - buffer: graduate File from experimental and expose as global
 - doc: apply suggestions from code review
Committers 1
 - Khafra <42794878+KhafraDev@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/47153
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Geoffrey Booth 
Reviewed-By: Robert Nagy 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47153
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Geoffrey Booth 
Reviewed-By: Robert Nagy 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 18 Mar 2023 21:34:05 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47153#pullrequestreview-1349416220
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/47153#pullrequestreview-1349430849
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/47153#pullrequestreview-1349668541
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/47153#pullrequestreview-1350351079
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-03-21T12:31:57Z: https://ci.nodejs.org/job/node-test-pull-request/50514/
- Querying data for job/node-test-pull-request/50514/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4482731187

nodejs-github-bot · 2023-03-21T18:56:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50529/

aduh95

We should remove the following in a follow up PR:

node/test/wpt/test-file.js

Lines 7 to 10 in 11e37e0

    
           runner.setInitScript(` 
        
             const { File } = require('buffer'); 
        
             globalThis.File = File; 
        
           `);

nodejs-github-bot · 2023-03-22T19:28:14Z

Landed in 7bc0e6a

KhafraDev · 2023-12-04T14:41:32Z

We don't implement HTML forms https://wicg.github.io/entries-api/#dom-file-webkitrelativepath

buffer: graduate File from experimental and expose as global

da112db

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 18, 2023

anonrig reviewed Mar 18, 2023

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 19, 2023

KhafraDev mentioned this pull request Mar 20, 2023

Implement File class #39015

Closed

anonrig reviewed Mar 20, 2023

View reviewed changes

doc/api/buffer.md Outdated Show resolved Hide resolved

doc/api/globals.md Outdated Show resolved Hide resolved

doc: apply suggestions from code review

fb57970

anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 20, 2023

KhafraDev force-pushed the make-file-global branch from cdb81c1 to fb57970 Compare March 20, 2023 21:14

anonrig approved these changes Mar 20, 2023

View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 20, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2023

mcollina approved these changes Mar 20, 2023

View reviewed changes

github-actions bot mentioned this pull request Mar 21, 2023

CI Reliability 2023-03-21 nodejs/reliability#531

Open

19 tasks

GeoffreyBooth approved these changes Mar 21, 2023

View reviewed changes

ronag approved these changes Mar 21, 2023

View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 21, 2023

github-actions bot mentioned this pull request Mar 22, 2023

CI Reliability 2023-03-22 nodejs/reliability#532

Open

19 tasks

aduh95 approved these changes Mar 22, 2023

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 22, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023

nodejs-github-bot merged commit 7bc0e6a into nodejs:main Mar 22, 2023

KhafraDev deleted the make-file-global branch March 22, 2023 19:58

KhafraDev mentioned this pull request Mar 22, 2023

test: remove useless WPT init scripts #47221

Closed

panva mentioned this pull request Mar 22, 2023

test: remove "make File a global" WPT init scripts #47223

Closed

github-actions bot mentioned this pull request Mar 23, 2023

CI Reliability 2023-03-23 nodejs/reliability#533

Open

33 tasks

RafaelGSS mentioned this pull request Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

ajsharp mentioned this pull request Apr 14, 2023

createTranscription File type does not exist in node openai/openai-node#127

Closed

eliot-akira mentioned this pull request May 24, 2023

Remove DOMParser from Blueprints: installPlugin and installTheme WordPress/wordpress-playground#427

Merged

char0n mentioned this pull request Aug 24, 2023

Node Versions char0n/swagger-ui-nextjs#1

Closed

PratikDev mentioned this pull request Oct 23, 2023

Validating file input colinhacks/zod#387

Closed

This comment was marked as abuse.

Sign in to view

ZuBB mentioned this pull request Apr 6, 2024

Support of "File" API in Node.js is missing in "Browser compatibility" section mdn/browser-compat-data#22786

Closed

	runner.setInitScript(`
	const { File } = require('buffer');
	globalThis.File = File;
	`);

Uh oh!

buffer: graduate File from experimental and expose as global #47153

buffer: graduate File from experimental and expose as global #47153

Uh oh!

Conversation

KhafraDev commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 18, 2023

Uh oh!

Uh oh!

anonrig commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 20, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 21, 2023

Uh oh!

GeoffreyBooth left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 21, 2023

Uh oh!

KhafraDev commented Mar 21, 2023

Uh oh!

nodejs-github-bot commented Mar 21, 2023

Uh oh!

nodejs-github-bot commented Mar 21, 2023

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 22, 2023

Uh oh!

This comment was marked as abuse.

This comment was marked as abuse.

KhafraDev commented Dec 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

KhafraDev commented Mar 18, 2023 •

edited

Loading

anonrig commented Mar 20, 2023 •

edited

Loading