Skip to content

[v18.x backport] test: fix test-net-happy-eyeballs without IPv6 support#47447

Closed
LiviaMedeiros wants to merge 1 commit intonodejs:v18.x-stagingfrom
LiviaMedeiros:backport-v18.x-45856
Closed

[v18.x backport] test: fix test-net-happy-eyeballs without IPv6 support#47447
LiviaMedeiros wants to merge 1 commit intonodejs:v18.x-stagingfrom
LiviaMedeiros:backport-v18.x-45856

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented Apr 6, 2023

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Apr 6, 2023
@LiviaMedeiros LiviaMedeiros mentioned this pull request Apr 6, 2023
Merged
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51840/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51841/

This was referenced May 18, 2023
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51990/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51996/

This was referenced May 30, 2023
Open
Open
Open
Open
Open
@ruyadorno
Copy link
Member

ruyadorno commented Aug 16, 2023

@LiviaMedeiros this PR needs rebasing

@LiviaMedeiros
test: fix test-net-autoselectfamily for kernel without IPv6 support
15b1c5a 
PR-URL: nodejs#45856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@LiviaMedeiros
Copy link
Member Author

LiviaMedeiros commented Aug 17, 2023

Now that #49016 has landed, #45856 should be pickable as is.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiviaMedeiros @nodejs-github-bot @ruyadorno