sqlite: add setReturnArrays method to StatementSync#57542
sqlite: add setReturnArrays method to StatementSync#57542nodejs-github-bot merged 15 commits intonodejs:mainfrom
Conversation
|
Review requested:
|
|
Cc @nodejs/cpp-reviewers |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57542 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01%
==========================================
Files 630 630
Lines 184990 185042 +52
Branches 36214 36232 +18
==========================================
+ Hits 166941 167008 +67
+ Misses 11002 10996 -6
+ Partials 7047 7038 -9
🚀 New features to boost your workflow:
|
|
Oh, and this needs documentation. |
|
I'll add docs once the code is approved |
|
I've opened #57569 to refactor the iterator implementation. I think we should land that PR before this one so that we can avoid exposing iterator internal state to JS. |
|
This needs a rebase, but we can finally move this forward. |
|
Yep, will rebase asap |
|
Landed in 054371d |
PR-URL: nodejs#57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #57542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
@gurgunday @cjihrig Was there any discussion of how the internal state of a |
PR-URL: nodejs#59074 Refs: nodejs#57542 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add a new StatementSync method setReturnArrays() that allows query results to be returned as arrays instead of objects. This is more efficient when column names are meaningless, auto-generated, or when working with hundreds of columns.
Fixes #57534
It's my first significant C++ PR, hopefully first of many :)