build: fix missing files warning#57870
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 19, 2025
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
RaisinTen
approved these changes
Apr 14, 2025
marco-ippolito
approved these changes
Apr 14, 2025
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Apr 14, 2025
Collaborator
This commit fixes the following warning:
Warning: Missing input files:
C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h
C:\Users\lpinca\node\deps\ncrypto\dh-primes.h
nodejs@bd3c25cf31282f101196 removed
`'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'` instead of
`'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'`
Refs: nodejs@5ab3140dfbf0dfa33a66
Refs: nodejs@b9b4cb7731168671d8f4
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
RafaelGSS
approved these changes
Apr 19, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2cff98c |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
This commit fixes the following warning:
Warning: Missing input files:
C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h
C:\Users\lpinca\node\deps\ncrypto\dh-primes.h
bd3c25cf31282f101196 removed
`'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'` instead of
`'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'`
Refs: 5ab3140dfbf0dfa33a66
Refs: b9b4cb7731168671d8f4
PR-URL: #57870
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
This commit fixes the following warning:
Warning: Missing input files:
C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h
C:\Users\lpinca\node\deps\ncrypto\dh-primes.h
bd3c25cf31282f101196 removed
`'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'` instead of
`'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'`
Refs: 5ab3140dfbf0dfa33a66
Refs: b9b4cb7731168671d8f4
PR-URL: #57870
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95
added
the
backport-requested-v22.x
Contributor
|
This doesn't land cleanly on |
Member
|
I think this does not apply on |
legendecas
added
dont-land-on-v20.x
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
This commit fixes the following warning:
Warning: Missing input files:
C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h
C:\Users\lpinca\node\deps\ncrypto\dh-primes.h
nodejs/node@bd3c25cf31282f101196 removed
`'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'` instead of
`'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'`
Refs: nodejs/node@5ab3140dfbf0dfa33a66
Refs: nodejs/node@b9b4cb7731168671d8f4
PR-URL: nodejs/node#57870
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the following warning:
bd3c25cf31282f101196 removed
'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'instead of'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'Refs: 5ab3140dfbf0dfa33a66
Refs: b9b4cb7731168671d8f4