Skip to content

build: fix zstd pkgname#57999

Merged
aduh95 merged 1 commit intonodejs:mainfrom
aduh95:zstd
Apr 26, 2025
Merged

build: fix zstd pkgname#57999
aduh95 merged 1 commit intonodejs:mainfrom
aduh95:zstd

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 24, 2025

When trying to build Node.js with --shared-zstd, I'm getting the following:

Package zstd was not found in the pkg-config search path.
Perhaps you should add the directory containing `zstd.pc'
to the PKG_CONFIG_PATH environment variable
Package 'zstd' not found

I've tried passing --shared-zstd-libname=libzstd without success, however this patch does make the error go away.

@aduh95 aduh95 requested a review from hybrist April 24, 2025 08:53
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 24, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 24, 2025
@aduh95 aduh95 changed the title build: fix zstd libname build: fix zstd pkgname Apr 24, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66434/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 24, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66442/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 25, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66445/

@aduh95 aduh95 merged commit 3e996df into nodejs:main Apr 26, 2025
70 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 26, 2025

Landed in 3e996df

@aduh95 aduh95 deleted the zstd branch April 26, 2025 09:07
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
build: fix zstd libname
f9f0314 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
build: fix zstd libname
77d11f9 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
build: fix zstd libname
4507590 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
build: fix zstd libname
9280eac 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
build: fix zstd libname
063e597 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
build: fix zstd libname
6d6b6b1 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
build: fix zstd libname
1b59950 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
build: fix zstd libname
9417b68 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
build: fix zstd libname
bd5147c 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
aduh95 added a commit that referenced this pull request May 18, 2025
@aduh95
build: fix zstd libname
7900f8f 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
build: fix zstd libname
718f874 
PR-URL: #57999
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jan Martin <jan.krems@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jun 5, 2025
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@hybrist hybrist hybrist approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@aduh95 @nodejs-github-bot @jasnell @hybrist @lpinca @anonrig @richardlau @marco-ippolito @jakecastelli @bjohansebas