Skip to content

src,sqlite: only pass xFilter when user provided a callback#63516

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:xFilter-changeset
Open

src,sqlite: only pass xFilter when user provided a callback#63516
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:xFilter-changeset

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 23, 2026

According to https://sqlite.org/session.html#sqlite3changeset_apply, passing NULL is allowed and does what we want; I assume it's more performant.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels May 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (8d3245e) to head (b6cce12).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63516   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         718      718           
  Lines      227984   227983    -1     
  Branches    42835    42825   -10     
=======================================
+ Hits       205522   205525    +3     
- Misses      14235    14240    +5     
+ Partials     8227     8218    -9     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.62% <100.00%> (-0.01%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@louwers
Copy link
Copy Markdown
Contributor

louwers commented May 23, 2026

LGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented May 23, 2026

@geeksilva97 please do not start fresh CI when it's not needed

If there are Jenkins CI failures unrelated to the change in the pull
request, try "Resume Build". It is in the left navigation of the relevant
`node-test-pull-request` job. (Do not be tempted to do this on the lower
level `node-test-commit` job as it will not report the updated result back
to the PR.) It will preserve all the green results from the current job but
re-run everything else. Start a fresh CI by pressing "Retry" if more than
seven days have elapsed since the original failing CI as the compiled
binaries for the Windows and ARM platforms are only kept for seven days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants