test: fix flaky test-child-process-pass-fd#8212
Closed
santigimeno wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix flaky test-child-process-pass-fd#8212santigimeno wants to merge 1 commit intonodejs:masterfrom
test-child-process-pass-fd#8212santigimeno wants to merge 1 commit intonodejs:masterfrom
Conversation
Listen on random ports instead of using `common.PORT`. Fixes: nodejs#8209
santigimeno
added
child_process
Member
|
LGTM if CI is OK |
Member
|
LGTM |
Contributor
|
LGTM |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 22, 2016
Listen on random ports instead of using `common.PORT`. Fixes: nodejs#8209 PR-URL: nodejs#8212 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Member
|
CI is all good except for a build failure. Given the small nature of the change and the disruptive nature of flaky tests, I'm going to land this now (PR has been open for 27 hours) rather than waiting the usual 48/72 hours. I don't imagine anyone will object, but if so, hey, speak up and I'll be more cautious in the future. Landed in 64cbe7a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Listen on random ports instead of using
common.PORT.Fixes: #8209