Closed
Conversation
nodejs-github-bot
added
doc
Member
|
Nit: I would use this subject line for the commit message: "doc: capitalize arguments' type names in url doc" as I find it a little more descriptive. Change LGTM. |
yorkie
force-pushed
the
fix/url-api-doc
branch
from
9202508 to
06f2126
Compare
Contributor
Author
|
@lpinca Done, thank you :) |
Member
|
LGTM. |
Member
|
LGTM |
yorkie
added a commit
that referenced
this pull request
Sep 15, 2016
PR-URL: #8489 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Landed at 68bf02d, thanks for reviews :) |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8489 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc, url
Description of change
The problem: these lower-cased native JavaScript types seems not to have detected to be links.
See https://nodejs.org/dist/latest-v6.x/docs/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost.