Skip to content

Commit 9481763

Browse files
realitykingmcollina
authored andcommitted
Don't add the Array.prototype.forEach replacement to files that don't use forEach. (#331)
1 parent 06058f0 commit 9481763

File tree

3 files changed

+1
-20
lines changed

3 files changed

+1
-20
lines changed

build/files.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ const headRegexp = /(^module.exports = \w+;?)/m
3636
, '\n$1\n Duplex = Duplex || require(\'./_stream_duplex\');\n'
3737
]
3838

39-
, altForEachImplReplacement = require('./common-replacements').altForEachImplReplacement
40-
, altForEachUseReplacement = require('./common-replacements').altForEachUseReplacement
4139
, altIndexOfImplReplacement = require('./common-replacements').altIndexOfImplReplacement
4240
, altIndexOfUseReplacement = require('./common-replacements').altIndexOfUseReplacement
4341

@@ -238,8 +236,6 @@ module.exports['_stream_duplex.js'] = [
238236
, instanceofReplacement
239237
, utilReplacement
240238
, stringDecoderReplacement
241-
, altForEachImplReplacement
242-
, altForEachUseReplacement
243239
, objectKeysReplacement
244240
, objectKeysDefine
245241
, processNextTickImport
@@ -258,11 +254,8 @@ module.exports['_stream_readable.js'] = [
258254
, addDuplexDec
259255
, requireReplacement
260256
, instanceofReplacement
261-
, altForEachImplReplacement
262-
, altForEachUseReplacement
263257
, altIndexOfImplReplacement
264258
, altIndexOfUseReplacement
265-
, instanceofReplacement
266259
, stringDecoderReplacement
267260
, isArrayReplacement
268261
, isArrayDefine

lib/_stream_duplex.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,4 @@ Duplex.prototype._destroy = function (err, cb) {
115115
this.end();
116116

117117
pna.nextTick(cb, err);
118-
};
119-
120-
function forEach(xs, f) {
121-
for (var i = 0, l = xs.length; i < l; i++) {
122-
f(xs[i], i);
123-
}
124-
}
118+
};

lib/_stream_readable.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,12 +1001,6 @@ function endReadableNT(state, stream) {
10011001
}
10021002
}
10031003

1004-
function forEach(xs, f) {
1005-
for (var i = 0, l = xs.length; i < l; i++) {
1006-
f(xs[i], i);
1007-
}
1008-
}
1009-
10101004
function indexOf(xs, x) {
10111005
for (var i = 0, l = xs.length; i < l; i++) {
10121006
if (xs[i] === x) return i;

0 commit comments

Comments
 (0)