Skip to content

Commit bd62ad2

Browse files
committed
moved the logic to replacements.mjs
Signed-off-by: Rishabh Bhandari <rishabhbhandari6@gmail.com>
1 parent de43dd6 commit bd62ad2

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

build/build.mjs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -172,17 +172,6 @@ async function main() {
172172
await rm('lib', { recursive: true, force: true })
173173
await rm('test', { recursive: true, force: true })
174174

175-
// remove obsolete methods from readable-stream
176-
const methodNameToRemove = ['fromWeb', 'toWeb']
177-
const readableStreamPath = resolve(__dirname, '../lib/internal/streams/readable.js')
178-
let readableStreamContent = await readFile(readableStreamPath, 'utf-8')
179-
180-
for (const method of methodNameToRemove) {
181-
const regex = new RegExp(`Readable.+${method} = function\\s\\s*\\([^)]*\\)\\s*{[^}]*}`, 'g')
182-
readableStreamContent = readableStreamContent.replace(regex, '')
183-
writeFileSync(readableStreamPath, readableStreamContent, 'utf8')
184-
}
185-
186175
// Download or open the tar file
187176
let tarFile
188177

build/replacements.mjs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
import { resolve } from 'node:path'
2+
import { writeFileSync } from 'node:fs'
3+
import { readFile } from 'node:fs/promises'
4+
15
const legacyStreamsRequireStream = ["require\\('stream'\\)", "require('./stream')"]
26

37
const internalStreamsBufferPolyfill = [
@@ -152,6 +156,17 @@ const testParallelIncludeTap = [
152156

153157
const testParallelImportStreamInMjs = [" from 'stream';", "from '../../lib/ours/index.js';"]
154158

159+
export const removeObsoleteReadableMethods = async function(methodNames) {
160+
const readableStreamPath = resolve(__dirname, '../lib/internal/streams/readable.js')
161+
let readableStreamContent = await readFile(readableStreamPath, 'utf-8')
162+
163+
for (const method of methodNames) {
164+
const regex = new RegExp(`Readable.+${method} = function\\s\\s*\\([^)]*\\)\\s*{[^}]*}`, 'g')
165+
readableStreamContent = readableStreamContent.replace(regex, '')
166+
writeFileSync(readableStreamPath, readableStreamContent, 'utf8')
167+
}
168+
}
169+
155170
const testParallelImportTapInMjs = ["(from 'assert';)", "$1\nimport tap from 'tap';"]
156171

157172
const testParallelDuplexFromBlob = [

0 commit comments

Comments
 (0)