Skip to content

Commit f033a0c

Browse files
kumavismcollina
authored andcommitted
v2.x - do not mutate core-util-is module (#423)
* build replacements - do not mutate core-util-is module * ci - use default npm version for non-legacy * ci - drop unused TASK env var
1 parent b3cf9b1 commit f033a0c

File tree

7 files changed

+15
-36
lines changed

7 files changed

+15
-36
lines changed

.travis.yml

Lines changed: 9 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,33 @@
11
sudo: false
22
language: node_js
33
before_install:
4-
- npm install -g npm@2
5-
- test $NPM_LEGACY && npm install -g npm@latest-3 || npm install npm -g
4+
- (test $NPM_LEGACY && npm install -g npm@2 && npm install -g npm@3) || true
65
notifications:
76
email: false
87
matrix:
98
fast_finish: true
109
include:
1110
- node_js: '0.8'
12-
env:
13-
- TASK=test
14-
- NPM_LEGACY=true
11+
env: NPM_LEGACY=true
1512
- node_js: '0.10'
16-
env:
17-
- TASK=test
18-
- NPM_LEGACY=true
13+
env: NPM_LEGACY=true
1914
- node_js: '0.11'
20-
env:
21-
- TASK=test
22-
- NPM_LEGACY=true
15+
env: NPM_LEGACY=true
2316
- node_js: '0.12'
24-
env:
25-
- TASK=test
26-
- NPM_LEGACY=true
17+
env: NPM_LEGACY=true
2718
- node_js: 1
28-
env:
29-
- TASK=test
30-
- NPM_LEGACY=true
19+
env: NPM_LEGACY=true
3120
- node_js: 2
32-
env:
33-
- TASK=test
34-
- NPM_LEGACY=true
21+
env: NPM_LEGACY=true
3522
- node_js: 3
36-
env:
37-
- TASK=test
38-
- NPM_LEGACY=true
23+
env: NPM_LEGACY=true
3924
- node_js: 4
40-
env: TASK=test
4125
- node_js: 5
42-
env: TASK=test
4326
- node_js: 6
44-
env: TASK=test
4527
- node_js: 7
46-
env: TASK=test
4728
- node_js: 8
48-
env: TASK=test
4929
- node_js: 9
50-
env: TASK=test
51-
script: "npm run $TASK"
30+
script: "npm run test"
5231
env:
5332
global:
5433
- secure: rE2Vvo7vnjabYNULNyLFxOyt98BoJexDqsiOnfiD6kLYYsiQGfr/sbZkPMOFm9qfQG7pjqx+zZWZjGSswhTt+626C0t/njXqug7Yps4c3dFblzGfreQHp7wNX5TFsvrxd6dAowVasMp61sJcRnB2w8cUzoe3RAYUDHyiHktwqMc=

build/files.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const headRegexp = /(^module.exports = \w+;?)/m
4141

4242
, utilReplacement = [
4343
/^const util = require\('util'\);/m
44-
, '\n/*<replacement>*/\nconst util = require(\'core-util-is\');\n'
44+
, '\n/*<replacement>*/\nconst util = Object.create(require(\'core-util-is\'));\n'
4545
+ 'util.inherits = require(\'inherits\');\n/*</replacement>*/\n'
4646
]
4747

lib/_stream_duplex.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ var objectKeys = Object.keys || function (obj) {
4343
module.exports = Duplex;
4444

4545
/*<replacement>*/
46-
var util = require('core-util-is');
46+
var util = Object.create(require('core-util-is'));
4747
util.inherits = require('inherits');
4848
/*</replacement>*/
4949

lib/_stream_passthrough.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = PassThrough;
3030
var Transform = require('./_stream_transform');
3131

3232
/*<replacement>*/
33-
var util = require('core-util-is');
33+
var util = Object.create(require('core-util-is'));
3434
util.inherits = require('inherits');
3535
/*</replacement>*/
3636

lib/_stream_readable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function _isUint8Array(obj) {
6464
/*</replacement>*/
6565

6666
/*<replacement>*/
67-
var util = require('core-util-is');
67+
var util = Object.create(require('core-util-is'));
6868
util.inherits = require('inherits');
6969
/*</replacement>*/
7070

lib/_stream_transform.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ module.exports = Transform;
6868
var Duplex = require('./_stream_duplex');
6969

7070
/*<replacement>*/
71-
var util = require('core-util-is');
71+
var util = Object.create(require('core-util-is'));
7272
util.inherits = require('inherits');
7373
/*</replacement>*/
7474

lib/_stream_writable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ var Duplex;
6464
Writable.WritableState = WritableState;
6565

6666
/*<replacement>*/
67-
var util = require('core-util-is');
67+
var util = Object.create(require('core-util-is'));
6868
util.inherits = require('inherits');
6969
/*</replacement>*/
7070

0 commit comments

Comments
 (0)