From f1c5a7d4ec2eb390ca5481e82c9882301c3e49d8 Mon Sep 17 00:00:00 2001 From: Anthony Fu Date: Tue, 12 Jul 2022 20:16:42 +0800 Subject: [PATCH 1/3] fix(vite-node): `process.dev` undefined in production causing FOUC --- packages/nuxt/src/core/runtime/nitro/renderer.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/nuxt/src/core/runtime/nitro/renderer.ts b/packages/nuxt/src/core/runtime/nitro/renderer.ts index 3562c6cabe9..9bfaf022021 100644 --- a/packages/nuxt/src/core/runtime/nitro/renderer.ts +++ b/packages/nuxt/src/core/runtime/nitro/renderer.ts @@ -57,7 +57,8 @@ const getSSRRenderer = lazyCachedFunction(async () => { async function renderToString (input, context) { const html = await _renderToString(input, context) // In development with vite-node, the manifest is on-demand and will be available after rendering - if (process.dev && process.env.NUXT_VITE_NODE_OPTIONS) { + if (process.env.NUXT_VITE_NODE_OPTIONS) { + console.log('HII') renderer.rendererContext.updateManifest(await getClientManifest()) } return `
${html}
` From f08e23666ed25f0a46be2b66e2e3213eeaf7b7df Mon Sep 17 00:00:00 2001 From: Anthony Fu Date: Tue, 12 Jul 2022 20:18:49 +0800 Subject: [PATCH 2/3] chore: update --- packages/nuxt/src/core/runtime/nitro/renderer.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/nuxt/src/core/runtime/nitro/renderer.ts b/packages/nuxt/src/core/runtime/nitro/renderer.ts index 9bfaf022021..b7547414905 100644 --- a/packages/nuxt/src/core/runtime/nitro/renderer.ts +++ b/packages/nuxt/src/core/runtime/nitro/renderer.ts @@ -58,7 +58,6 @@ const getSSRRenderer = lazyCachedFunction(async () => { const html = await _renderToString(input, context) // In development with vite-node, the manifest is on-demand and will be available after rendering if (process.env.NUXT_VITE_NODE_OPTIONS) { - console.log('HII') renderer.rendererContext.updateManifest(await getClientManifest()) } return `
${html}
` From 245a39b774e37a441a21fd88b7f41db8442fdca3 Mon Sep 17 00:00:00 2001 From: Anthony Fu Date: Tue, 12 Jul 2022 20:26:43 +0800 Subject: [PATCH 3/3] fix: replace `process.dev` --- packages/nuxt/src/core/nitro.ts | 3 ++- packages/nuxt/src/core/runtime/nitro/renderer.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/nuxt/src/core/nitro.ts b/packages/nuxt/src/core/nitro.ts index 1d67b635246..b0a88f895a0 100644 --- a/packages/nuxt/src/core/nitro.ts +++ b/packages/nuxt/src/core/nitro.ts @@ -94,7 +94,8 @@ export async function initNitro (nuxt: Nuxt) { ...nuxt.options.alias }, replace: { - 'process.env.NUXT_NO_SSR': nuxt.options.ssr === false + 'process.env.NUXT_NO_SSR': nuxt.options.ssr === false, + 'process.dev': nuxt.options.dev }, rollupConfig: { plugins: [] diff --git a/packages/nuxt/src/core/runtime/nitro/renderer.ts b/packages/nuxt/src/core/runtime/nitro/renderer.ts index b7547414905..3562c6cabe9 100644 --- a/packages/nuxt/src/core/runtime/nitro/renderer.ts +++ b/packages/nuxt/src/core/runtime/nitro/renderer.ts @@ -57,7 +57,7 @@ const getSSRRenderer = lazyCachedFunction(async () => { async function renderToString (input, context) { const html = await _renderToString(input, context) // In development with vite-node, the manifest is on-demand and will be available after rendering - if (process.env.NUXT_VITE_NODE_OPTIONS) { + if (process.dev && process.env.NUXT_VITE_NODE_OPTIONS) { renderer.rendererContext.updateManifest(await getClientManifest()) } return `
${html}
`