From 73822737063ad92bb3d891aa661d9768428f48d7 Mon Sep 17 00:00:00 2001 From: Andreas Greimel Date: Fri, 4 Nov 2022 17:40:23 +0100 Subject: [PATCH] Fix default scroll behavior for routes without page transition Related issue: https://github.com/nuxt/framework/issues/8699 `router.options.ts` falsely thinks that an `undefined` page transition is `true`, meaning it HAS a transition. Whereas `page.mjs` correctly interprets an `undefined` transition as `false`. --- packages/nuxt/src/pages/runtime/router.options.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nuxt/src/pages/runtime/router.options.ts b/packages/nuxt/src/pages/runtime/router.options.ts index ce63f731aca..44f82ba9dcd 100644 --- a/packages/nuxt/src/pages/runtime/router.options.ts +++ b/packages/nuxt/src/pages/runtime/router.options.ts @@ -31,7 +31,7 @@ export default { } // Wait for `page:transition:finish` or `page:finish` depending on if transitions are enabled or not - const hasTransition = to.meta.pageTransition !== false && from.meta.pageTransition !== false + const hasTransition = !!(to.meta.pageTransition && from.meta.pageTransition) const hookToWait = hasTransition ? 'page:transition:finish' : 'page:finish' return new Promise((resolve) => { nuxtApp.hooks.hookOnce(hookToWait, async () => {