Skip to content

Commit 12a3c43

Browse files
committed
Update to use new EfiGuidError definition
1 parent 4910c3c commit 12a3c43

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

src/lib/efivar/types/efi_guid.rs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use super::EfiGuidError;
2-
use crate::types::efi_guid_error;
32
use std::cmp::Ordering;
43
use std::convert::TryFrom;
54
use std::fmt;
@@ -110,9 +109,9 @@ macro_rules! try_from_byte_slice {
110109
Ok(o) => Ok(Self::from(o)),
111110
Err(_) => {
112111
if len < 16 {
113-
Err(efi_guid_error::SRC_SLICE_LENGTH_TOO_SHORT)
112+
Err(EfiGuidError::SliceLengthTooShort)
114113
} else {
115-
Err(efi_guid_error::SRC_SLICE_LENGTH_TOO_LONG)
114+
Err(EfiGuidError::SliceLengthTooLong)
116115
}
117116
}
118117
};
@@ -132,9 +131,9 @@ macro_rules! try_from_byte_vec {
132131
Ok(a) => Ok(EfiGuid::from(&a)),
133132
Err(_o) => {
134133
if vec_len < 16 {
135-
Err(efi_guid_error::SRC_VEC_LENGTH_TOO_SHORT)
134+
Err(EfiGuidError::VecLengthTooShort)
136135
} else {
137-
Err(efi_guid_error::SRC_VEC_LENGTH_TOO_LONG)
136+
Err(EfiGuidError::VecLengthTooLong)
138137
}
139138
}
140139
}
@@ -163,21 +162,21 @@ impl FromStr for EfiGuid {
163162
fn from_str(value: &str) -> Result<Self, EfiGuidError> {
164163
let chars: Vec<char> = value.chars().into_iter().collect();
165164
if chars.len() != 36 {
166-
return Err(efi_guid_error::BAD_FORMAT);
165+
return Err(EfiGuidError::BadFormat);
167166
}
168167
let digits = chars
169168
.into_iter()
170169
.enumerate()
171170
.filter_map(|(i, c)| {
172171
if i == 8 || i == 13 || i == 18 || i == 23 {
173172
if c != '-' {
174-
return Some(Err(efi_guid_error::BAD_FORMAT));
173+
return Some(Err(EfiGuidError::BadFormat));
175174
}
176175
return None;
177176
}
178177
return match c.to_digit(16) {
179178
Some(d) => Some(Ok(d as u8)),
180-
None => Some(Err(efi_guid_error::BAD_FORMAT)),
179+
None => Some(Err(EfiGuidError::BadFormat)),
181180
};
182181
})
183182
.collect::<Result<Vec<u8>, _>>()?;
@@ -201,7 +200,7 @@ impl FromStr for EfiGuid {
201200
.collect::<Vec<u8>>(),
202201
) {
203202
Ok(o) => Ok(o),
204-
Err(_) => Err(efi_guid_error::BAD_FORMAT),
203+
Err(_) => Err(EfiGuidError::BadFormat),
205204
}
206205
.unwrap(),
207206
});

src/lib/efivar/types/efi_guid_error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ impl fmt::Display for EfiGuidError {
3333
}
3434
}
3535

36-
impl Error for EfiGuidError {};
36+
impl Error for EfiGuidError {}

0 commit comments

Comments
 (0)