Skip to content

Commit f7fef60

Browse files
authored
Replace semicolons with ampersands (#457)
* Replace semicolons with ampersands * update changes
1 parent 749f27e commit f7fef60

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

CHANGES

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
- Replace semicolons with ampersands in URL parameters @svenvg93
12
- fix AnotherCurl.pm to use --help all @Strykar
23
- remove dsa and add ed25519 in ssh keyscan by @StalkR and @lelutin
34
- add support for fwmark option in fping 5.2+. Supports 'fwmark' keyword in FPing probe

htdocs/js/smokeping.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ function changeRRDImage(coords,dimensions){
108108
EndEpoch = Math.ceil(EndEpoch + (SelectRight - (RRDImgWidth - RRDRight) ) * DivEpoch / RRDImgUsable * RightFactor);
109109

110110

111-
$('zoom').src = myURL + '?displaymode=a;start=' + StartEpoch + ';end=' + EndEpoch + ';target=' + Target + ';hierarchy=' + Hierarchy;
111+
$('zoom').src = myURL + '?displaymode=a&start=' + StartEpoch + '&end=' + EndEpoch + '&target=' + Target + '&hierarchy=' + Hierarchy;
112112

113113
myCropper.setParams();
114114

@@ -119,7 +119,7 @@ if($('range_form') != null && $('range_form').length){
119119
$form = $(this);
120120
var cgiurl = $form.action.split("?");
121121
var action = $form.serialize().split("&");
122-
action = action.map(i=> i + ';');
122+
action = action.map(i=> i + '&');
123123
$form.action = cgiurl[0] + "?" + action[4] + action[5] + action[6] + action[3];
124124
}));
125125
}

lib/Smokeping.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1553,7 +1553,7 @@ sub get_detail ($$$$;$){
15531553
$page .= "<div class=\"".panel_heading_class()."\"><h2>$title</h2></div>";
15541554
}
15551555
$page .= "<div class=\"panel-body\">";
1556-
$page .= ( qq{<a href="}.cgiurl($q,$cfg)."?".hierarchy($q).qq{displaymode=n;start=$startstr;end=now;}."target=".$t.$s.'">'
1556+
$page .= ( qq{<a href="}.cgiurl($q,$cfg)."?".hierarchy($q).qq{displaymode=n&start=$startstr&end=now&}."target=".$t.$s.'">'
15571557
. qq{<IMG ALT="" SRC="${imghref}${s}_${end}_${start}.svg">}."</a>" ); #"
15581558
$page .= "</div></div>\n";
15591559
}

lib/Smokeping/Graphs.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ sub get_multi_detail ($$$$;$){
351351
$page .= "<div class=\"panel-heading\"><h2>$desc</h2></div>"
352352
if $cfg->{Presentation}{htmltitle} eq 'yes';
353353
$page .= "<div class=\"panel-body\">";
354-
$page .= ( qq{<a href="?displaymode=n;start=$startstr;end=now;}."target=".$q->param('target').'">'
354+
$page .= ( qq{<a href="?displaymode=n&start=$startstr&end=now&}."target=".$q->param('target').'">'
355355
. qq{<IMG ALT="" SRC="${imghref}_${end}_${start}.svg" class="img-responsive">}."</a>" ); #"
356356
$page .= "</div></div>\n";
357357
} else { # chart mode

0 commit comments

Comments
 (0)