Skip to content

Commit 856b986

Browse files
titaiwangmsCopilot
andcommitted
docs(changelog): correct arch-diff note — old diff sees the added If, not in-branch changes
The previous wording over-claimed that #328 introduces a change "the old top-level diff could not see". The old diff DOES report the newly-added per-layer If phase-split nodes. Reword to the accurate future-proofing framing: #328 adds the first control-flow subgraph structure; once those If nodes exist, FUTURE changes inside their branches would be invisible to the old (subgraph-collapsing) diff, so the recursion is landed now to keep in-branch changes visible going forward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent dab98b9 commit 856b986

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2929

3030
- The Architecture-Diff CI tool (`src/mobius/_graph_diff.py`) now recurses into
3131
`If` / `Loop` / `Scan` `GRAPH`-typed attributes instead of collapsing them to a
32-
bare type string, so changes *inside* control-flow subgraphs are visible in the
32+
bare type marker, so changes *inside* control-flow subgraphs are visible in the
3333
diff. A dedicated `subgraph_structure_change` (MODERATE) severity is emitted for
3434
structural in-branch deltas (node added/removed/rewired, branch added/removed),
35-
while pure inner-attribute tweaks stay `changed_attrs` (MINOR). Added here
36-
because this PR introduces the static-cache per-layer phase-split
37-
`If(Greater(seq_len, 1))` — the first control-flow/subgraph change the old
38-
top-level-only diff could not see — so the tool that guards architectural
39-
changes must be able to see it. Developer-tooling only; no exported-graph or
40-
runtime impact.
35+
while pure inner-attribute tweaks stay `changed_attrs` (MINOR). This PR introduces
36+
the first control-flow/subgraph *structure* into the exported graphs — the
37+
static-cache per-layer phase-split `If(Greater(seq_len, 1))`. The previous
38+
top-level diff already reports those newly-added `If` nodes; what it could not do
39+
is see *inside* a branch. Once these `If` nodes exist, any future change within
40+
their branches would be invisible to the old diff (which collapsed each subgraph
41+
to a type marker), so the recursion is added now to keep such in-branch changes
42+
visible going forward. Developer-tooling only; no exported-graph or runtime impact.
4143

4244
---
4345

0 commit comments

Comments
 (0)