Merge pull request #2 from open-rpc/BelfordZ/fix-npm-install-error

BelfordZ · web-flow · commit b693e15462d8 · 2024-11-28T14:53:33.000-08:00
Fix npm install error by removing monaco-vim and updating dependencies
diff --git a/.node-version b/.node-version
@@ -1 +1 @@
-14.17.5
+18.20.5
diff --git a/.nodenv b/.nodenv
@@ -1 +1 @@
-14.17.5
+18.20.5
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+18.20.5
diff --git a/README.md b/README.md
@@ -1 +1,13 @@
-WIP WIP
+# Using nvm
+
+This project uses `nvm` to manage Node.js versions. To use the correct Node.js version, run the following command in the root of the repository and in each package directory:
+
+```sh
+nvm use
+```
+
+If you do not have the required Node.js version installed, you can install it using the following command:
+
+```sh
+nvm install
+```
diff --git a/package.json b/package.json
@@ -20,6 +20,6 @@
     "turbo": "^1.0.0"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=18.20.5"
   }
 }
diff --git a/packages/docs-react/.nvmrc b/packages/docs-react/.nvmrc
@@ -0,0 +1 @@
+18.20.5
diff --git a/packages/docs-react/package.json b/packages/docs-react/package.json
@@ -42,7 +42,8 @@
     "json-schema-ref-parser": "^7.0.1",
     "ts-jest": "^24.0.0",
     "tslint": "^5.14.0",
-    "typescript": "^3.9.7"
+    "typescript": "^3.9.7",
+    "react-scripts": "3.4.4"
   },
   "files": [
     "build"
diff --git a/packages/inspector/.nvmrc b/packages/inspector/.nvmrc
@@ -0,0 +1 @@
+18.20.5
diff --git a/packages/inspector/package.json b/packages/inspector/package.json
@@ -22,15 +22,15 @@
   "author": "",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@rescripts/cli": "0.0.13",
-    "@rescripts/utilities": "0.0.6",
+    "@rescripts/cli": "latest",
+    "@rescripts/utilities": "0.0.7",
     "@types/jest": "^24.0.13",
     "@types/qs": "^6.5.3",
     "@types/react-dom": "^16.8.4",
     "@types/use-persisted-state": "^0.3.0",
     "jest": "24.9.0",
     "monaco-editor-webpack-plugin": "^1.7.0",
-    "react-scripts": "^3.3.0",
+    "react-scripts": "3.4.4",
     "ts-jest": "^24.0.2",
     "tslint": "^5.17.0",
     "typescript": "^3.7.3"
@@ -61,7 +61,6 @@
     "@rehooks/window-size": "^1.0.2",
     "acorn-dynamic-import": "^4.0.0",
     "monaco-editor": "^0.18.1",
-    "monaco-vim": "0.0.14",
     "qs": "^6.8.0",
     "react": "^16.12.0",
     "react-dom": "^16.12.0",
diff --git a/packages/inspector/src/containers/JSONRPCRequestEditor.tsx b/packages/inspector/src/containers/JSONRPCRequestEditor.tsx
@@ -5,7 +5,6 @@ import { MethodObject, OpenrpcDocument } from "@open-rpc/meta-schema";
 import useWindowSize from "@rehooks/window-size";
 import { addDiagnostics } from "@etclabscore/monaco-add-json-schema-diagnostics";
 import openrpcDocumentToJSONRPCSchema from "../helpers/openrpcDocumentToJSONRPCSchema";
-import useMonacoVimMode from "../hooks/useMonacoVimMode";
 
 interface IProps {
   onChange?: (newValue: any) => void;
@@ -16,7 +15,6 @@ interface IProps {
 
 const JSONRPCRequestEditor: React.FC<IProps> = (props) => {
   const [editor, setEditor] = useState();
-  useMonacoVimMode(editor);
   const windowSize = useWindowSize();
   useEffect(() => {
     if (editor) {
diff --git a/packages/inspector/src/containers/OptionsEditor.tsx b/packages/inspector/src/containers/OptionsEditor.tsx
@@ -4,7 +4,6 @@ import * as monaco from "monaco-editor";
 import { JSONSchema, MethodObject } from "@open-rpc/meta-schema";
 import useWindowSize from "@rehooks/window-size";
 import { addDiagnostics } from "@etclabscore/monaco-add-json-schema-diagnostics";
-import useMonacoVimMode from "../hooks/useMonacoVimMode";
 
 interface IProps {
   onChange?: (newValue: any) => void;
@@ -15,7 +14,6 @@ interface IProps {
 
 const OptionsEditor: React.FC<IProps> = (props) => {
   const [editor, setEditor] = useState();
-  useMonacoVimMode(editor);
   const windowSize = useWindowSize();
   useEffect(() => {
     if (editor) {
diff --git a/packages/inspector/src/hooks/useMonacoVimMode.ts b/packages/inspector/src/hooks/useMonacoVimMode.ts
diff --git a/packages/logs-react/.nvmrc b/packages/logs-react/.nvmrc
@@ -0,0 +1 @@
+18.20.5
diff --git a/packages/logs-react/package.json b/packages/logs-react/package.json
@@ -9,7 +9,7 @@
   ],
   "publishConfig": {
     "access": "public"
-  },
+  ],
   "scripts": {
     "start": "rescripts start",
     "build": "rescripts build",
@@ -20,12 +20,12 @@
   "author": "",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@rescripts/cli": "0.0.14",
+    "@rescripts/cli": "latest",
     "@rescripts/utilities": "0.0.7",
     "@types/jest": "^24.0.13",
     "@types/react-dom": "16.9.4",
     "monaco-editor-webpack-plugin": "1.7.0",
-    "react-scripts": "3.4.1",
+    "react-scripts": "3.4.4",
     "ts-jest": "^24.0.2",
     "tslint": "^5.17.0",
     "typescript": "^3.7.3"
diff --git a/packages/playground/.nvmrc b/packages/playground/.nvmrc
@@ -0,0 +1 @@
+18.20.5
diff --git a/packages/playground/__mocks__/monaco-vim.js b/packages/playground/__mocks__/monaco-vim.js
diff --git a/packages/playground/package.json b/packages/playground/package.json
@@ -31,7 +31,6 @@
     "jsonschema": "^1.2.4",
     "lodash": "^4.17.21",
     "monaco-editor": "^0.18.1",
-    "monaco-vim": "0.0.14",
     "open": "^6.4.0",
     "qs": "^6.11.0",
     "react": "^16.12.0",
@@ -61,8 +60,8 @@
     "not op_mini all"
   ],
   "devDependencies": {
-    "@rescripts/cli": "0.0.13",
-    "@rescripts/utilities": "0.0.6",
+    "@rescripts/cli": "latest",
+    "@rescripts/utilities": "0.0.7",
     "@types/classnames": "^2.2.9",
     "@types/css-mediaquery": "^0.1.0",
     "@types/jest": "^24.0.23",
@@ -73,7 +72,7 @@
     "@types/react-dom": "^16.8.4",
     "css-mediaquery": "^0.1.2",
     "monaco-editor-webpack-plugin": "^1.7.0",
-    "react-scripts": "^3.4.3",
+    "react-scripts": "3.4.4",
     "tslint": "^6.1.3",
     "typescript": "^3.7.3"
   },
diff --git a/packages/playground/src/App.tsx b/packages/playground/src/App.tsx
@@ -20,7 +20,6 @@ import searchBarStore from "./stores/searchBarStore";
 import examples from "./examplesList";
 import OpenRPCEditor from "./OpenRPCEditor";
 import useMonacoReplaceMetaSchema from "./hooks/useMonacoReplaceMetaSchema";
-import useMonacoVimMode from "./hooks/useMonacoVimMode";
 import { IExample } from "./ExampleDocumentsDropdown/ExampleDocumentsDropdown";
 import Inspector from "@open-rpc/inspector";
 import useInspectorActionStore from "./stores/inspectorActionStore";
@@ -54,7 +53,6 @@ const App: React.FC = () => {
   };
   const [inspectorContents] = useInspectorActionStore();
   useMonacoReplaceMetaSchema(editor);
-  useMonacoVimMode(editor);
 
   const handleEditorDidMount = (__: any, ed: any) => {
     setEditor(ed);
diff --git a/packages/playground/src/hooks/useMonacoVimMode.tsx b/packages/playground/src/hooks/useMonacoVimMode.tsx

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,6 @@`
`20`	`20`	`"turbo": "^1.0.0"`
`21`	`21`	`},`
`22`	`22`	`"engines": {`
`23`		`- "node": ">=14.0.0"`
	`23`	`+ "node": ">=18.20.5"`
`24`	`24`	`}`
`25`	`25`	`}`