Skip to content

Commit cae746e

Browse files
committed
Fix npm install error by removing monaco-vim and updating dependencies
Resolve npm install error by removing `monaco-vim` dependency and ensuring consistent versions of `react-scripts` and `@rescripts/utilities`. * **Remove `monaco-vim` dependency:** - Delete `monaco-vim` from `packages/inspector/package.json` and `packages/playground/package.json`. - Delete `packages/inspector/src/hooks/useMonacoVimMode.ts` and `packages/playground/src/hooks/useMonacoVimMode.tsx`. - Delete `packages/playground/__mocks__/monaco-vim.js`. * **Update files to remove `useMonacoVimMode` hook:** - Remove import and usage of `useMonacoVimMode` in `packages/inspector/src/containers/JSONRPCRequestEditor.tsx`. - Remove import and usage of `useMonacoVimMode` in `packages/inspector/src/containers/OptionsEditor.tsx`. - Remove import and usage of `useMonacoVimMode` in `packages/playground/src/App.tsx`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/open-rpc/tools?shareId=XXXX-XXXX-XXXX-XXXX).
1 parent 6869ccf commit cae746e

File tree

8 files changed

+0
-95
lines changed

8 files changed

+0
-95
lines changed

packages/inspector/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
"@rehooks/window-size": "^1.0.2",
6262
"acorn-dynamic-import": "^4.0.0",
6363
"monaco-editor": "^0.18.1",
64-
"monaco-vim": "0.0.14",
6564
"qs": "^6.8.0",
6665
"react": "^16.12.0",
6766
"react-dom": "^16.12.0",

packages/inspector/src/containers/JSONRPCRequestEditor.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { MethodObject, OpenrpcDocument } from "@open-rpc/meta-schema";
55
import useWindowSize from "@rehooks/window-size";
66
import { addDiagnostics } from "@etclabscore/monaco-add-json-schema-diagnostics";
77
import openrpcDocumentToJSONRPCSchema from "../helpers/openrpcDocumentToJSONRPCSchema";
8-
import useMonacoVimMode from "../hooks/useMonacoVimMode";
98

109
interface IProps {
1110
onChange?: (newValue: any) => void;
@@ -16,7 +15,6 @@ interface IProps {
1615

1716
const JSONRPCRequestEditor: React.FC<IProps> = (props) => {
1817
const [editor, setEditor] = useState();
19-
useMonacoVimMode(editor);
2018
const windowSize = useWindowSize();
2119
useEffect(() => {
2220
if (editor) {

packages/inspector/src/containers/OptionsEditor.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import * as monaco from "monaco-editor";
44
import { JSONSchema, MethodObject } from "@open-rpc/meta-schema";
55
import useWindowSize from "@rehooks/window-size";
66
import { addDiagnostics } from "@etclabscore/monaco-add-json-schema-diagnostics";
7-
import useMonacoVimMode from "../hooks/useMonacoVimMode";
87

98
interface IProps {
109
onChange?: (newValue: any) => void;
@@ -15,7 +14,6 @@ interface IProps {
1514

1615
const OptionsEditor: React.FC<IProps> = (props) => {
1716
const [editor, setEditor] = useState();
18-
useMonacoVimMode(editor);
1917
const windowSize = useWindowSize();
2018
useEffect(() => {
2119
if (editor) {

packages/inspector/src/hooks/useMonacoVimMode.ts

Lines changed: 0 additions & 40 deletions
This file was deleted.

packages/playground/__mocks__/monaco-vim.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/playground/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
"jsonschema": "^1.2.4",
3232
"lodash": "^4.17.21",
3333
"monaco-editor": "^0.18.1",
34-
"monaco-vim": "0.0.14",
3534
"open": "^6.4.0",
3635
"qs": "^6.11.0",
3736
"react": "^16.12.0",

packages/playground/src/App.tsx

100755100644
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import searchBarStore from "./stores/searchBarStore";
2020
import examples from "./examplesList";
2121
import OpenRPCEditor from "./OpenRPCEditor";
2222
import useMonacoReplaceMetaSchema from "./hooks/useMonacoReplaceMetaSchema";
23-
import useMonacoVimMode from "./hooks/useMonacoVimMode";
2423
import { IExample } from "./ExampleDocumentsDropdown/ExampleDocumentsDropdown";
2524
import Inspector from "@open-rpc/inspector";
2625
import useInspectorActionStore from "./stores/inspectorActionStore";
@@ -54,7 +53,6 @@ const App: React.FC = () => {
5453
};
5554
const [inspectorContents] = useInspectorActionStore();
5655
useMonacoReplaceMetaSchema(editor);
57-
useMonacoVimMode(editor);
5856

5957
const handleEditorDidMount = (__: any, ed: any) => {
6058
setEditor(ed);

packages/playground/src/hooks/useMonacoVimMode.tsx

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)