Skip to content

Commit b2c22ae

Browse files
authored
[chore] Run make gogci (#45013)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Codewise, this PR is simply the result of running `make gogci` locally. I've also added it as a check on PRs in `build-and-test` to ensure it's been run by users, and added it to every `make generate` call to hopefully make it so developers don't need to manually run it.
1 parent 7796b78 commit b2c22ae

File tree

157 files changed

+99
-246
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

157 files changed

+99
-246
lines changed

.github/workflows/build-and-test.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,10 @@ jobs:
188188
run: |
189189
make gotidy
190190
git diff --exit-code || (echo 'go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.' && exit 1)
191+
- name: Check for go package import order
192+
run: |
193+
make gogci
194+
git diff --exit-code || (echo 'go package imports not formatted, please run "make gogci" and commit the changes in this PR.' && exit 1)
191195
- name: Gen distributions
192196
run: |
193197
make gendistributions

Makefile.Common

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,9 +273,11 @@ generate: generate-tools
273273
ifeq ($(CURDIR),$(SRC_ROOT))
274274
PATH="$(TOOLS_BIN_DIR_PORTABLE):$$PATH" $(MAKE) for-all CMD="$(GOCMD) generate ./..."
275275
$(MAKE) gofmt
276+
$(MAKE) gogci
276277
else
277278
PATH="$(TOOLS_BIN_DIR_PORTABLE):$$PATH" $(GOCMD) generate ./...
278279
$(MAKE) fmt
280+
$(MAKE) gci
279281
endif
280282

281283
.PHONY: lint

connector/grafanacloudconnector/internal/metadata/generated_telemetry.go

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connector/grafanacloudconnector/internal/metadata/generated_telemetry_test.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connector/grafanacloudconnector/internal/metadatatest/generated_telemetrytest_test.go

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connector/servicegraphconnector/internal/metadata/generated_telemetry.go

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connector/servicegraphconnector/internal/metadata/generated_telemetry_test.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

connector/servicegraphconnector/internal/metadatatest/generated_telemetrytest_test.go

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

exporter/elasticsearchexporter/internal/metadata/generated_telemetry.go

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

exporter/elasticsearchexporter/internal/metadata/generated_telemetry_test.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)