exporter/kafkaexporter: tidy up; support partitioning in all encodings#39001
Merged
MovieStoreGuy merged 9 commits intoopen-telemetry:mainfrom Apr 7, 2025
Merged
Conversation
axw
force-pushed
the
kafkaexporter-refactor-marshalers
branch
2 times, most recently
from
eb11083 to
f445e50
Compare
- Move marshaler implementations to internal package - Simplify code to obtain a marshaler given an encoding name - Make marshalers independent of Sarama (Kafka client) - Extract partitioning logic out of marshalers, with the exception of Jaeger marshalers - Implement a generic Kafka exporter with type parameter for signal-specific parts - Create more tightly scoped unit tests for encodings, independent of the general functionality of the exporter
axw
force-pushed
the
kafkaexporter-refactor-marshalers
branch
from
f445e50 to
f0c9700
Compare
Contributor
MovieStoreGuy
left a comment
MovieStoreGuy
left a comment
There was a problem hiding this comment.
Sorry, not a complete review but I wanted to give a start.
Contributor
Author
|
This isn't just a chore, it fixes #38999 I'll add a changelog |
axw
changed the title
axw
changed the title
This was referenced Apr 2, 2025
MovieStoreGuy
approved these changes
Apr 7, 2025
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
open-telemetry#39001) #### Description - Move marshaler implementations to internal package - Simplify code to obtain a marshaler given an encoding name - Make marshalers independent of Sarama (Kafka client) - Implement a generic Kafka exporter with type parameter for signal-specific parts - Create more tightly scoped unit tests for encodings, independent of the general functionality of the exporter - Added tests for partitioning logic #### Link to tracking issue Fixes open-telemetry#38999 #### Testing Unit tests added. #### Documentation N/A
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
open-telemetry#39001) #### Description - Move marshaler implementations to internal package - Simplify code to obtain a marshaler given an encoding name - Make marshalers independent of Sarama (Kafka client) - Implement a generic Kafka exporter with type parameter for signal-specific parts - Create more tightly scoped unit tests for encodings, independent of the general functionality of the exporter - Added tests for partitioning logic #### Link to tracking issue Fixes open-telemetry#38999 #### Testing Unit tests added. #### Documentation N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #38999
Testing
Unit tests added.
Documentation
N/A