feature: use-distro-packages (#35)

* remove grpc, abseil, curl and openssl compilation

* fix resolution of grpc cpp plugin

* only fetch submodules if we're building the container

* add a user to the build environment rather than working from root

* fix $HOME env variable

* consolidate apt-get in base Dockerfile

* move bcc package requirement to base

* move libbpf package requirements to base

* move libuv removal to base image

* set base username

* add explicit error prints to user verification

* add sudo package

* consolidate package installations and add sudo

* fix PATH

* add debug print to bcc

* export PATH to .bashrc in base container

* write to .profile so /bin/sh will pick up

* bring libuv1 removal back to the uv container as it was removing cmake

* add chown on copying bcc files

* add chown to COPY in libuv

* hardcode uid, gid for test

* export UID and GID as env variables for chown

* add chown statements to all relevant COPY statements

* add ssh and ag to packages in final

* switch to multi-line RUN to get Docker to allow multi-line

* remove CFLAGS setting, it seems to end up empty anyway

* create output directory

* reset UNAME for LZ4 which seems to depend on it

* fix lz4 builds

* reduce container sizes by making them into multi-stage builds

* re-comment clause that was accidentally un-commented

* add protoc flag (required since we apparently downgraded protoc versions)

* add missing library dependencies

* remove the now redundant Dockerfiles and submodules, and their mentions in the GHA

* switch to podman for building images

* add missing package

* update to bookworm

* add libpolly, required by bcc

* add CMAKE_BUILD_TYPE and BUILD_CFLAGS arguments

* bcc build examins the git repo, so check a standalone version

* install python libs via apt, as suggested by pip3

* fix apt install clause

* auto-run workflow on push and PR, with dry run

* disable fossa and ossf-scorecard on contributor repos

* add --break-system-packages to `pip3 install pcpp` since an apt package is not available for bookworm

* reorder less-changing layers in final to earlier position, to leverage layer caching

* add uidmap, required by podman

* fix permissions for podman to work inside the build environment

* remove flotsam (oops)

* set clang-tidy and clang-format to version 16

* add slirp4netns for podman

* remove the pull request trigger; it does not have permissions to push to ghcr

Author: yonch

.github/actions/build-push-container/action.yml

@@ -54,15 +54,6 @@ runs:
         ref: ${{ inputs.ref }}
         fetch-depth: 0
 
-    - name: Initialize directory-specific submodules
-      shell: bash
-      run: |
-        DIRECTORY="${{ inputs.directory }}"
-        echo "Initializing submodules for directory: ${DIRECTORY}"
-        
-        # Initialize submodules for the specific directory path
-        git submodule update --init --recursive -- "${DIRECTORY}/"
-
     - name: Compute recursive tags for all directories
       id: compute-recursive-tags
       shell: bash
@@ -74,24 +65,20 @@ runs:
         # Define dependency mapping based on CMakeLists.txt
         declare -A DEPS
         DEPS["base"]=""
-        DEPS["openssl"]="base"
         DEPS["bcc"]="base"
         DEPS["libuv"]="base"
         DEPS["cpp_misc"]="base"
         DEPS["go"]="base"
-        DEPS["abseil_cpp"]="base"
         DEPS["libmaxminddb"]="base"
         DEPS["libbpf"]="base"
-        DEPS["curl"]="base openssl"
-        DEPS["grpc_cpp"]="base abseil_cpp openssl"
-        DEPS["aws_sdk"]="base openssl curl"
-        DEPS["gcp_cpp"]="base openssl curl grpc_cpp"
-        DEPS["opentelemetry"]="base grpc_cpp"
-        DEPS["final"]="base openssl curl bcc libuv aws_sdk cpp_misc go grpc_cpp abseil_cpp libmaxminddb gcp_cpp opentelemetry libbpf"
+        DEPS["aws_sdk"]="base"
+        DEPS["gcp_cpp"]="base"
+        DEPS["opentelemetry"]="base"
+        DEPS["final"]="base bcc libuv aws_sdk cpp_misc go libmaxminddb gcp_cpp opentelemetry libbpf"
         
         # Compute direct hashes for all directories upfront
         declare -A DIRECT_HASHES
-        ALL_DIRS="base openssl bcc libuv cpp_misc go abseil_cpp libmaxminddb libbpf curl grpc_cpp aws_sdk gcp_cpp opentelemetry final"
+        ALL_DIRS="base bcc libuv cpp_misc go libmaxminddb libbpf aws_sdk gcp_cpp opentelemetry final"
         
         echo "Computing direct hashes..." >&2
         for dir in $ALL_DIRS; do
@@ -187,7 +174,6 @@ runs:
         
         # Compute all dependency tags for build args
         echo "Computing all dependency tags..." >&2
-        ALL_DIRS="base openssl bcc libuv cpp_misc go abseil_cpp libmaxminddb libbpf curl grpc_cpp aws_sdk gcp_cpp opentelemetry final"
         
         for dir in $ALL_DIRS; do
           if [[ "$dir" != "$DIRECTORY" ]]; then
@@ -220,6 +206,17 @@ runs:
           echo "Image ${FULL_IMAGE_TAG} does not exist in registry"
         fi
 
+    - name: Initialize directory submodules
+      if: steps.check-exists.outputs.exists == 'false'
+      shell: bash
+      run: |
+        DIRECTORY="${{ inputs.directory }}"
+        echo "Initializing submodules for directory: ${DIRECTORY}"
+        
+        # Initialize submodules for the specific directory path
+        git submodule update --init --recursive -- "${DIRECTORY}/"
+
+
     - name: Log in to Container Registry
       if: steps.check-exists.outputs.exists == 'false'
       uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
@@ -240,16 +237,12 @@ runs:
         
         # Add all dependency image tags as build args using outputs from compute-recursive-tags step
         BUILD_ARGS="${BUILD_ARGS} --build-arg base_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.base_IMAGE_TAG }}"
-        BUILD_ARGS="${BUILD_ARGS} --build-arg openssl_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.openssl_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg bcc_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.bcc_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg libuv_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.libuv_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg cpp_misc_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.cpp_misc_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg go_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.go_IMAGE_TAG }}"
-        BUILD_ARGS="${BUILD_ARGS} --build-arg abseil_cpp_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.abseil_cpp_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg libmaxminddb_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.libmaxminddb_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg libbpf_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.libbpf_IMAGE_TAG }}"
-        BUILD_ARGS="${BUILD_ARGS} --build-arg curl_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.curl_IMAGE_TAG }}"
-        BUILD_ARGS="${BUILD_ARGS} --build-arg grpc_cpp_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.grpc_cpp_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg aws_sdk_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.aws_sdk_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg gcp_cpp_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.gcp_cpp_IMAGE_TAG }}"
         BUILD_ARGS="${BUILD_ARGS} --build-arg opentelemetry_IMAGE_TAG=${{ steps.compute-recursive-tags.outputs.opentelemetry_IMAGE_TAG }}"
@@ -264,6 +257,15 @@ runs:
           BUILD_ARGS="${BUILD_ARGS} --build-arg BENV_BASE_IMAGE_VERSION=${BENV_BASE_IMAGE_VERSION}"
         fi
         
+        # Add CMAKE_BUILD_TYPE (defaults to Release if not set)
+        CMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE:-Release}"
+        BUILD_ARGS="${BUILD_ARGS} --build-arg CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}"
+        
+        # Add BUILD_CFLAGS based on build type
+        if [ "${CMAKE_BUILD_TYPE}" = "Debug" ]; then
+          BUILD_ARGS="${BUILD_ARGS} --build-arg BUILD_CFLAGS='-O0 -g'"
+        fi
+        
         # Build the image
         echo "Building image: ${FULL_IMAGE_TAG}"
         echo "Build args: ${BUILD_ARGS}"