Skip to content

Commit 1a1421f

Browse files
authored
Use JSON formatting for all values except strings (#2644)
1 parent 8f7094b commit 1a1421f

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,6 @@ def _sanitize(self, key: str) -> str:
211211
# pylint: disable=no-self-use
212212
def _check_value(self, value: Union[int, float, str, Sequence]) -> str:
213213
"""Check the label value and return is appropriate representation"""
214-
if not isinstance(value, str) and isinstance(value, Sequence):
214+
if not isinstance(value, str):
215215
return dumps(value, default=str)
216216
return str(value)

exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,3 +205,6 @@ def test_check_value(self):
205205
self.assertEqual(collector._check_value([1, 2]), "[1, 2]")
206206
self.assertEqual(collector._check_value((1, 2)), "[1, 2]")
207207
self.assertEqual(collector._check_value(["a", 2]), '["a", 2]')
208+
self.assertEqual(collector._check_value(True), "true")
209+
self.assertEqual(collector._check_value(False), "false")
210+
self.assertEqual(collector._check_value(None), "null")

0 commit comments

Comments
 (0)