Skip to content

Commit d00aaea

Browse files
ocelotlAlex Boten
andauthored
Mark test as flaky (#2437)
Fixes #2436 Co-authored-by: Alex Boten <aboten@lightstep.com>
1 parent 28a67e3 commit d00aaea

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import time
1616
from unittest.mock import Mock
1717

18+
from flaky import flaky
19+
1820
from opentelemetry.sdk._metrics.export import (
1921
MetricExporter,
2022
PeriodicExportingMetricReader,
@@ -99,13 +101,14 @@ def test_ticker_called(self):
99101
self.assertTrue(collect_mock.assert_called_once)
100102
pmr.shutdown()
101103

104+
@flaky(max_runs=3, min_passes=1)
102105
def test_ticker_collects_metrics(self):
103106
exporter = FakeMetricsExporter()
104107

105108
pmr = self._create_periodic_reader(
106109
metrics_list, exporter, interval=100
107110
)
108-
time.sleep(0.11)
111+
time.sleep(0.15)
109112
self.assertEqual(exporter.metrics, metrics_list)
110113
pmr.shutdown()
111114

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ deps =
7070
-c dev-requirements.txt
7171
opentelemetry: pytest
7272
opentelemetry: pytest-benchmark
73+
opentelemetry: flaky
7374
coverage: pytest
7475
coverage: pytest-cov
7576
mypy,mypyinstalled: mypy

0 commit comments

Comments
 (0)