From ae694343027c669771666c7cfa31170eeeea9463 Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Thu, 11 Feb 2021 11:54:18 -0800 Subject: [PATCH 1/2] update limits as per specification --- opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py index 0a6eefbd843..b7b00d9ed1e 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py @@ -61,11 +61,11 @@ logger = logging.getLogger(__name__) SPAN_ATTRIBUTE_COUNT_LIMIT = int( - environ.get(OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT, 1000) + environ.get(OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT, 128) ) -SPAN_EVENT_COUNT_LIMIT = int(environ.get(OTEL_SPAN_EVENT_COUNT_LIMIT, 1000)) -SPAN_LINK_COUNT_LIMIT = int(environ.get(OTEL_SPAN_LINK_COUNT_LIMIT, 1000)) +SPAN_EVENT_COUNT_LIMIT = int(environ.get(OTEL_SPAN_EVENT_COUNT_LIMIT, 128)) +SPAN_LINK_COUNT_LIMIT = int(environ.get(OTEL_SPAN_LINK_COUNT_LIMIT, 128)) VALID_ATTR_VALUE_TYPES = (bool, str, int, float) # pylint: disable=protected-access TRACE_SAMPLER = sampling._get_from_env_or_default() From f98499972d3f7b6241b25fa7c22af6e6c702d364 Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Thu, 11 Feb 2021 11:58:16 -0800 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55a550dda24..7357859895e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Tracer and Meter provider environment variables are now consistent with the rest ([#1571](https://github.com/open-telemetry/opentelemetry-python/pull/1571)]) +- Limits for Span attributes, events and links have been updated to 128 + ([1597](https://github.com/open-telemetry/opentelemetry-python/pull/1597)]) ### Added - Added `end_on_exit` argument to `start_as_current_span`