From b36a76ca848caf9596d0c28a65216dfcb2c25c69 Mon Sep 17 00:00:00 2001 From: David Cotten Date: Fri, 19 Jan 2024 22:15:08 -0700 Subject: [PATCH 1/2] Fix: Include key in attribute sequence warning --- opentelemetry-api/src/opentelemetry/attributes/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/opentelemetry-api/src/opentelemetry/attributes/__init__.py b/opentelemetry-api/src/opentelemetry/attributes/__init__.py index 724c931c826..783d18163ec 100644 --- a/opentelemetry-api/src/opentelemetry/attributes/__init__.py +++ b/opentelemetry-api/src/opentelemetry/attributes/__init__.py @@ -68,9 +68,10 @@ def _clean_attribute( # Reject attribute value if sequence contains a value with an incompatible type. if element_type not in _VALID_ATTR_VALUE_TYPES: _logger.warning( - "Invalid type %s in attribute value sequence. Expected one of " + "Invalid type %s in attribute '%s' value sequence. Expected one of " "%s or None", element_type.__name__, + key, [ valid_type.__name__ for valid_type in _VALID_ATTR_VALUE_TYPES From 1dc547eef8556cc32b4f8ee79e001496d4b53563 Mon Sep 17 00:00:00 2001 From: Diego Hurtado Date: Tue, 30 Jan 2024 21:44:19 -0600 Subject: [PATCH 2/2] Add CHANGELOG entry --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6dd0ee3b7de..f9b0b2104de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +- Include key in attribute sequence warning + ([#3639](https://github.com/open-telemetry/opentelemetry-python/pull/3639)) - Handle HTTP 2XX responses as successful in OTLP exporters ([#3623](https://github.com/open-telemetry/opentelemetry-python/pull/3623)) - Improve Resource Detector timeout messaging