From 05c85bcdcfc54a11ed83cd7d1b60babc54f09c2a Mon Sep 17 00:00:00 2001
From: kmohr-soprasteria <57349523+kmohr-soprasteria@users.noreply.github.com>
Date: Mon, 2 Jun 2025 10:48:39 +0200
Subject: [PATCH] (Notifications) Kafka parameters required - update spec
 accordingly Fixes #1197

---
 spec/MicroWaveDeviceInventory+config.json     |  2 +-
 spec/MicroWaveDeviceInventory+services.yaml   |  2 +-
 .../CyclicControlConstructRetrievalProcess.md | 19 ++++++++++---------
 .../DeviceListMetadataDescription.md          |  2 +-
 4 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/spec/MicroWaveDeviceInventory+config.json b/spec/MicroWaveDeviceInventory+config.json
index 47fc184a..54c7b31f 100644
--- a/spec/MicroWaveDeviceInventory+config.json
+++ b/spec/MicroWaveDeviceInventory+config.json
@@ -9649,7 +9649,7 @@
                   "password": " >>> password <<< "
                 },
                 "topic-name": "proper_notifications",
-                "client-id": "mwdi-consumer",
+                "client-id": "mwdi-instance-01",
                 "group-id": "mwdi-consumer-group"
               },
               "kafka-client-interface-status": {
diff --git a/spec/MicroWaveDeviceInventory+services.yaml b/spec/MicroWaveDeviceInventory+services.yaml
index df44272f..3c65076b 100644
--- a/spec/MicroWaveDeviceInventory+services.yaml
+++ b/spec/MicroWaveDeviceInventory+services.yaml
@@ -978,7 +978,7 @@ clients:
       uuid: mwdi-2-0-0-tcp-c-kmb-1-0-0-000
     kafka-client:
       uuid: mwdi-2-0-0-kmb-c-kmb-1-0-0-000
-      topic-name:
+      topic-name: proper_notifications
 
   - http-client:
       application-name: MicroWaveDeviceInventory
diff --git a/spec/additionalDescription/CyclicControlConstructRetrievalProcess.md b/spec/additionalDescription/CyclicControlConstructRetrievalProcess.md
index 5eff1c5a..fb33daca 100644
--- a/spec/additionalDescription/CyclicControlConstructRetrievalProcess.md
+++ b/spec/additionalDescription/CyclicControlConstructRetrievalProcess.md
@@ -141,15 +141,16 @@ The following schema shows how both processes are working collaboratively on upd
 The metadata table introduced in 1.2.x is replaced by the deviceMetadataList metadata attributes. I.e. the deviceMetadataList no longer consists only of the devices, but also stores the additional metadata attributes.  
 
 The additional metadata comprises the following attributes:
-- mount-name:
-- connection-status: 
-- changed-to-disconnected-time: 
-- added-to-device-list-time: 
-- last-complete-control-construct-update-time-attempt:
-- last-control-construct-notification-update-time:
-- number-of-partial-updates-since-last-complete-update:
-- schema-cache-directory:
-- device-type:
+- mount-name
+- connection-status
+- changed-to-disconnected-time
+- added-to-device-list-time
+- last-complete-control-construct-update-time-attempt
+- last-successful-complete-control-construct-update-time
+- last-control-construct-notification-update-time
+- number-of-partial-updates-since-last-complete-update
+- schema-cache-directory
+- device-type
 - locked-status: for internal use only
 
 For managing the slidingWindow and qualityMeasurement processes, the metadata is accessed directly, i.e. without calling of additional services.  
diff --git a/spec/additionalDescription/DeviceListMetadataDescription.md b/spec/additionalDescription/DeviceListMetadataDescription.md
index 76e99c7f..9c327507 100644
--- a/spec/additionalDescription/DeviceListMetadataDescription.md
+++ b/spec/additionalDescription/DeviceListMetadataDescription.md
@@ -26,7 +26,7 @@ The table shall contain the following columns:
   - Is set upon both successful or unsuccessful retrieval
   - Is used for retrieval prioritization
   - If the device is no longer connected, the timestamp is set to null, to ensure the CC gets retrieved again with priority if the device gets connected again
-- **last-complete-control-construct-update-time**:
+- **last-successful-complete-control-construct-update-time**:
   - the last time, the CC has successfully been updated completely
   - If the device is no longer disconnected, the timestamp is kept. If the deletion policy for historical CCs is set to "keep-on-disconnect", this attributes indicates how old the CC for the disconnected device in the cache is
 - **last-control-construct-notification-update-time**: