Feature/ci from siae 1.2.0#329
Merged
Merged
Conversation
- Add ESLint with reasonable rules for the codebase - Add lint and lint:fix npm scripts - Restructure GitHub Actions workflow to separate lint and test jobs - Add lint job that runs before tests (with job dependency) - Add PR-specific coverage comment that displays metrics in pull requests - Restrict CI triggers to main and develop branches - Add ESLint configuration with sensible defaults for Node.js/Express app The pipeline now enforces code quality standards while being pragmatic about auto-generated code (controllers, api routes) that shouldn't be linted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Change lint job to continue-on-error: true so it doesn't block the build - Remove hard dependency between lint and test jobs - Allows PRs to proceed with linting warnings while enforcing tests This pragmatic approach supports code quality improvements over time while not breaking existing workflows due to auto-generated code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Push events now trigger pipeline on all branches (useful for feature branches) - Pull request events still only trigger on main and develop - Provides faster CI feedback for all branches while keeping gate on main/develop Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
latta-siae
requested review from
kaya-siae,
mishra-siae and
ramineedi-siae
as code owners
fix missing comma in the file package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.