Use Arm64-aware wording when WSL reports virtualization off (#594)

* Use Arm64-aware wording when WSL reports virtualization off

The SetupEngine preflight-wsl step previously surfaced x86-only firmware
terminology (VT-x/AMD-V, BIOS/UEFI) when wsl.exe reported
'virtualization is not enabled'. On ARM64 devices (e.g. Surface) those
terms don't apply, leaving the remediation message confusing.

Split TryGetEnvironmentIssue into a public 1-arg method that delegates
to a new internal overload taking System.Runtime.InteropServices.
Architecture. The Arm64 branch emits UEFI-/Intune-aware wording;
other architectures keep the existing x64 wording. RuntimeInformation.
OSArchitecture reflects OS arch (not process arch), so this works even
when the app runs as win-x64 under Prism on ARM64 Windows.

Fixes #593

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Retrigger CI

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: RBrid

src/OpenClaw.SetupEngine/SetupSteps.cs

@@ -2,6 +2,7 @@
 using System.Net;
 using System.Net.Http;
 using System.Net.Sockets;
+using System.Runtime.InteropServices;
 using System.Text.Json;
 using OpenClaw.Connection;
 using OpenClaw.Shared;
@@ -107,18 +108,32 @@ public static bool SupportsDirectNamedInstall(Version version)
     // sentences are not, and over-broad fallbacks just create false
     // positives.
     public static bool TryGetEnvironmentIssue(string output, out string message)
+        => TryGetEnvironmentIssue(output, RuntimeInformation.OSArchitecture, out message);
+
+    // Architecture-aware overload. Internal so tests can exercise both x64
+    // and Arm64 wordings without depending on the host process arch.
+    internal static bool TryGetEnvironmentIssue(string output, Architecture architecture, out string message)
     {
         var text = Normalize(output);
 
-        // Firmware virtualization off (VT-x/AMD-V disabled in BIOS/UEFI).
-        // wsl.exe emits this when the Windows feature is installed but the
-        // CPU virtualization extension is turned off; remediation requires
-        // a trip into firmware settings, not `wsl --install`.
+        // Firmware virtualization off. wsl.exe emits this when the Windows
+        // feature is installed but the CPU virtualization extension is
+        // turned off; remediation requires a trip into firmware settings,
+        // not `wsl --install`. The remediation wording differs by CPU
+        // architecture: VT-x/AMD-V/SVM are x86-specific terms that don't
+        // exist on Arm64 (Surface Pro X / Pro 9 SQ3 / Pro 11), where the
+        // extensions are ARMv8 EL2 and the UEFI label is generic.
         if (Contains(text, "virtualization is not enabled"))
         {
-            message = "WSL2 requires hardware virtualization, but it is disabled in firmware. "
-                + "Enable VT-x/AMD-V (Intel VT or AMD SVM) in your computer's BIOS/UEFI settings, "
-                + "reboot, then retry setup.";
+            message = architecture == Architecture.Arm64
+                ? "WSL2 requires hardware virtualization, but it is disabled. "
+                    + "On ARM64 devices (e.g. Surface), enable virtualization in your device's UEFI "
+                    + "settings (look for 'Virtualization Support' or similar). On managed devices this "
+                    + "may be controlled by your organization's Intune / device-management policy. "
+                    + "Reboot, then retry setup."
+                : "WSL2 requires hardware virtualization, but it is disabled in firmware. "
+                    + "Enable VT-x/AMD-V (Intel VT or AMD SVM) in your computer's BIOS/UEFI settings, "
+                    + "reboot, then retry setup.";
             return true;
         }
 

tests/OpenClaw.SetupEngine.Tests/SetupStepsTests.cs

@@ -1,6 +1,7 @@
 using OpenClaw.Connection;
 using System.Net;
 using System.Net.Sockets;
+using System.Runtime.InteropServices;
 
 namespace OpenClaw.SetupEngine.Tests;
 
@@ -600,11 +601,31 @@ public void WslInstallSupport_TryGetEnvironmentIssue_DetectsFirmwareVirtualizati
             "WSL2 is unable to start since virtualization is not enabled on this machine. "
             + "Please ensure the 'Virtual Machine Platform' optional component is enabled "
             + "and virtualization is turned on in your computer's firmware settings.",
+            Architecture.X64,
             out var message));
         Assert.Contains("BIOS", message, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("VT-x", message, StringComparison.OrdinalIgnoreCase);
         Assert.Contains("virtualization", message, StringComparison.OrdinalIgnoreCase);
     }
 
+    [Fact]
+    public void WslInstallSupport_TryGetEnvironmentIssue_UsesArm64WordingOnArm64()
+    {
+        Assert.True(WslInstallSupport.TryGetEnvironmentIssue(
+            "WSL2 is unable to start since virtualization is not enabled on this machine. "
+            + "Please ensure the 'Virtual Machine Platform' optional component is enabled "
+            + "and virtualization is turned on in your computer's firmware settings.",
+            Architecture.Arm64,
+            out var message));
+        Assert.Contains("ARM64", message, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("UEFI", message, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("virtualization", message, StringComparison.OrdinalIgnoreCase);
+        // Must not name x86-specific extensions on ARM64.
+        Assert.DoesNotContain("VT-x", message, StringComparison.OrdinalIgnoreCase);
+        Assert.DoesNotContain("AMD-V", message, StringComparison.OrdinalIgnoreCase);
+        Assert.DoesNotContain("SVM", message, StringComparison.OrdinalIgnoreCase);
+    }
+
     [Fact]
     public void WslInstallSupport_TryGetEnvironmentIssue_DetectsCanonical0x80370102Error()
     {
@@ -649,7 +670,8 @@ public async Task PreflightWsl_FailsTerminalWhenVirtualizationDisabledInFirmware
 
         Assert.Equal(StepOutcome.FailedTerminal, result.Outcome);
         Assert.Contains("virtualization", result.Message, StringComparison.OrdinalIgnoreCase);
-        Assert.Contains("BIOS", result.Message, StringComparison.OrdinalIgnoreCase);
+        // Don't assert on "BIOS" / "UEFI" here -- the wording flexes by host
+        // CPU architecture (this test runs on either x64 or Arm64 dev boxes).
     }
 
     [Fact]