From 0b51aed6bb0cb4657075dfe2ff5fdfe2b2979fdd Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Sat, 23 May 2026 12:55:36 +0000
Subject: [PATCH] eng(build): enforce TreatWarningsAsErrors across all source
 projects

Adds <TreatWarningsAsErrors>true</TreatWarningsAsErrors> to src/Directory.Build.props
so compiler warnings in source code fail the build rather than accumulating silently.

All source projects currently produce 0 warnings; no behaviour change at HEAD.

The one intentional non-exhaustive switch in ExecApprovalsCoordinator (CS8524) is
suppressed via <NoWarn>CS8524</NoWarn> in OpenClaw.Shared.csproj because the
switch deliberately omits a _ arm so developers notice when a new enum value is
added. A comment in the csproj explains the rationale.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/Directory.Build.props                  | 7 +++++++
 src/OpenClaw.Shared/OpenClaw.Shared.csproj | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index e869350d2..37442164d 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -11,6 +11,13 @@
     <!-- Audit all package dependencies (direct + transitive) for known CVEs during restore.
          Defaults to "direct" in the SDK; "all" provides broader security coverage. -->
     <NuGetAuditMode>all</NuGetAuditMode>
+
+    <!-- Treat compiler warnings as errors across all source projects.
+         Keeps the warning count at zero and prevents silent warning accumulation
+         that is later expensive to clean up. Individual projects may suppress a
+         specific warning via <NoWarn> only when the warning is intentional and
+         the suppression is documented. -->
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
 </Project>
diff --git a/src/OpenClaw.Shared/OpenClaw.Shared.csproj b/src/OpenClaw.Shared/OpenClaw.Shared.csproj
index 82b057ea2..cead66ca8 100644
--- a/src/OpenClaw.Shared/OpenClaw.Shared.csproj
+++ b/src/OpenClaw.Shared/OpenClaw.Shared.csproj
@@ -5,6 +5,12 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <RootNamespace>OpenClaw.Shared</RootNamespace>
+    <!-- CS8524: switch expression on an enum without a _ arm — intentional in
+         ExecApprovalsCoordinator so the compiler flags any new enum member that
+         is added without a corresponding case.  The remaining int-cast space
+         (e.g. (ExecApprovalPromptOutcome)4) is an acceptable gap given that all
+         callers produce only named values. -->
+    <NoWarn>$(NoWarn);CS8524</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>