ignore generated man files#119
Conversation
|
LGTM |
| /oci-image-validate | ||
|
|
||
| *.1 | ||
| *.patch |
There was a problem hiding this comment.
Who makes these *.patch files?
There was a problem hiding this comment.
we always work with patch, and easy to forget to remove them before adding. I think it'd better to ignore them.
There was a problem hiding this comment.
I use *.patch files in projects where contribution is by mailing patches to a mailing list. But I personally don't use them much in push-based projects like those on GitHub. If you generate *.patch files as part of your personal workflow with this project, I think you should add a local ignore rule (gitignore(5) gives $HOME/.config/git/ignore and $GIT_DIR/info/exclude as possible locations). But if rules in the committed .gitignore are based on workflow idiosyncrasies, it becomes hard to maintain them.
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Mashimiao
force-pushed
the
fix-ignore
branch
from
99c37e8 to
1434e4c
Compare
Mashimiao
changed the title
|
1434e4c looks good to me. |
|
@cyphar btw PullApprove should catch your LGTMs moving forward, it was a misconfiguration on my end |
|
LGTM |
|
@opencontainers/image-tools-maintainers PTAL |
|
LGTM |
5 participants
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com