when should prestart hooks be called

[hqhq]

I just realized that we define prestart hooks MUST be called after the start operation is called, it's been there since we restore hook language removed by create/start split in #532 , but we actually call prestart hooks in create operation which before start operation in runc, and this should be the right approach in practice, should we amend language in runtime-spec or should we reconsider implementation in runc?

[hqhq]

/cc @crosbymichael @mrunalp @cyphar @dqminh

[wking]

On Thu, Aug 17, 2017 at 05:29:46AM -0700, Qiang Huang wrote: … but we actually call prestart hooks in create operation which before start operation in runc…

As I mentioned in f636808's commit message from #532, I think a hook that executes at the end of the ‘create’ operation should be called ‘postcreate’.

[hqhq]

Logically I think the definition is reasonable in runtime-spec, I think we can discuss this in runc first. Opened opencontainers/runc#1574 .