From b280c07d44a2d50cdb503cefd27ac62c61e3c7bc Mon Sep 17 00:00:00 2001 From: Ismo Puustinen Date: Thu, 6 Apr 2023 15:26:29 +0300 Subject: [PATCH 1/2] config-linux: clarify the "MB:"-line filtering in RDT. The thinking is that the runtimes should not do the filtering of values, but instead just apply the values in order. This way the possible MB-lines in l3CacheSchema will become overwritten by memBwSchema values (if the domains overlap). Note that we can't just concatenate the values because kernel will error out if the same domain is attempted to be set multiple times within one write() call. Signed-off-by: Ismo Puustinen --- config-linux.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/config-linux.md b/config-linux.md index 65a18d4d5..03e2aef4a 100644 --- a/config-linux.md +++ b/config-linux.md @@ -754,9 +754,7 @@ The following parameters can be specified for the container: The following rules on parameters MUST be applied: -* If both `l3CacheSchema` and `memBwSchema` are set, runtimes MUST write the combined value to the `schemata` file in that sub-directory discussed in `closID`. - -* If `l3CacheSchema` contains a line beginning with `MB:`, the value written to `schemata` file MUST be the non-`MB:` line(s) from `l3CacheSchema` and the line from `memBWSchema`. +* If both `l3CacheSchema` and `memBwSchema` are set, runtimes MUST write the values to the `schemata` file in that sub-directory discussed in `closID`. The runtimes MUST write `l3CacheSchema` first and `memBwSchema` last. * If either `l3CacheSchema` or `memBwSchema` is set, runtimes MUST write the value to the `schemata` file in the that sub-directory discussed in `closID`. From a6c310aa55daf30860113e121d4eaa23e3c010d0 Mon Sep 17 00:00:00 2001 From: Ismo Puustinen Date: Thu, 6 Apr 2023 15:36:26 +0300 Subject: [PATCH 2/2] config-linux: clarify when the RDT sub-directory should be removed. Signed-off-by: Ismo Puustinen --- config-linux.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/config-linux.md b/config-linux.md index 03e2aef4a..5c27f9bbf 100644 --- a/config-linux.md +++ b/config-linux.md @@ -770,6 +770,10 @@ The following rules on parameters MUST be applied: * If `closID` is set, and none of `l3CacheSchema`, `memBwSchema` or `schemata` are set, runtime MUST check if corresponding pre-configured directory `closID` is present in mounted `resctrl`. If such pre-configured directory `closID` exists, runtime MUST assign container to this `closID` and [generate an error](runtime.md#errors) if directory does not exist. +* If `closID` is not set and the runtime has created the sub-directory, the runtime MUST remove the sub-directory when the container is deleted. + +* If `closID` is set or the runtime has not created the sub-directory, the runtime MUST NOT remove the sub-directory when the container is deleted. + * If `enableMonitoring` is set, the runtime MUST create a dedicated MON group for the container. The runtime MUST use the container ID from [`start`](runtime.md#start) as the name of the MON group, i.e. create