Skip to content

Change HugepageLimit.Limit type to uint64#198

Merged
vbatts merged 1 commit into
opencontainers:masterfrom
runcom:hugepagetlb-limit-type
Sep 17, 2015
Merged

Change HugepageLimit.Limit type to uint64#198
vbatts merged 1 commit into
opencontainers:masterfrom
runcom:hugepagetlb-limit-type

Conversation

@runcom
Copy link
Copy Markdown
Member

@runcom runcom commented Sep 17, 2015

As in kernel

Signed-off-by: Antonio Murdaca runcom@linux.com

@wking
Copy link
Copy Markdown
Contributor

wking commented Sep 17, 2015

On Thu, Sep 17, 2015 at 12:19:44PM -0700, Antonio Murdaca wrote:

As in kernel

I didn't see anything about uint64 in a quick skim over 1, but it's
pretty clear from [2](I think that's the right setting ;), so looks
good to me.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom runcom force-pushed the hugepagetlb-limit-type branch from 6a30a1a to 6b5a66f Compare September 17, 2015 22:48
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@vbatts
Copy link
Copy Markdown
Member

vbatts commented Sep 17, 2015

LGTM

vbatts added a commit that referenced this pull request Sep 17, 2015
Change HugepageLimit.Limit type to uint64
@vbatts vbatts merged commit 96bcd04 into opencontainers:master Sep 17, 2015
@runcom runcom deleted the hugepagetlb-limit-type branch September 17, 2015 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants