build: upgrade django-stubs and djangorestframework-stubs - #36053
Merged
Conversation
kdmccormick
force-pushed
the
kdmccormick/django-stubs
branch
from
January 2, 2025 15:59
321ddfa to
1d6d6b9
Compare
kdmccormick
marked this pull request as ready for review
January 2, 2025 16:03
...now that we're on django>=4.2
This clunky yet type-safe workaround to this django-stubs issue, which arose when we upgraded django-stubs in the previous commits: typeddjango/django-stubs#1802
...not a Serializer, as it overrides to_representation to a str rather than a dictionary. This type error arose during the djangorestframework-stubs upgrade in the previous commits.
kdmccormick
force-pushed
the
kdmccormick/django-stubs
branch
from
January 2, 2025 16:19
1d6d6b9 to
33174db
Compare
salman2013
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...now that we're on django>=4.2
This will allow us to annotate Django-based and DRF-based code more expressively and correctly going forward. It should have no functional impact.
See individual commits for more details.